Bug 115060 - Don't create compositing layers for sticky position unless using the ScrollingCoordinator
Summary: Don't create compositing layers for sticky position unless using the Scrollin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-23 14:23 PDT by Simon Fraser (smfr)
Modified: 2013-04-23 15:00 PDT (History)
5 users (show)

See Also:

Attachments
Patch (10.37 KB, patch)
2013-04-23 14:25 PDT, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2013-04-23 14:23:06 PDT 
Don't create compositing layers for sticky position unless using the ScrollingCoordinator
Comment 1 Simon Fraser (smfr) 2013-04-23 14:25:44 PDT 
Created attachment 199325 [details]
Patch
Comment 2 Tim Horton 2013-04-23 14:28:57 PDT 
Comment on attachment 199325 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199325&action=review

> Source/WebCore/rendering/RenderLayerCompositor.cpp:2193
> +        if (ScrollingCoordinator* scrollingCoordinator = this->scrollingCoordinator())
> +            compositeSticky = scrollingCoordinator->coordinatesScrollingForFrameView(m_renderView->frameView());
> +        return compositeSticky;

The same logic exists in other places (shouldCompositeOverflowControls, for one). Should we maybe factor it out?
Comment 3 Simon Fraser (smfr) 2013-04-23 15:00:39 PDT 
http://trac.webkit.org/changeset/148998