Bug 115057 - Filled out more cases of branch folding in bytecode when emitting expressions into a branching context
Summary: Filled out more cases of branch folding in bytecode when emitting expressions...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-23 14:08 PDT by Geoffrey Garen
Modified: 2013-04-26 23:42 PDT (History)
4 users (show)

See Also:

Attachments
Patch (36.04 KB, patch)
2013-04-23 14:40 PDT, Geoffrey Garen 		fpizlo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2013-04-23 14:08:02 PDT 
Filled out more cases of branch folding in bytecode when emitting expressions into a branching context
Comment 1 Geoffrey Garen 2013-04-23 14:40:18 PDT 
Created attachment 199328 [details]
Patch
Comment 2 Filip Pizlo 2013-04-23 14:42:49 PDT 
Comment on attachment 199328 [details]
Patch

Cool!
Comment 3 WebKit Commit Bot 2013-04-23 14:47:39 PDT 
Attachment 199328 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/js/regress/branch-fold-expected.txt', u'LayoutTests/fast/js/regress/branch-fold.html', u'LayoutTests/fast/js/regress/script-tests/branch-fold.js', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/JavaScriptCore.order', u'Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp', u'Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h', u'Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp', u'Source/JavaScriptCore/parser/ASTBuilder.h', u'Source/JavaScriptCore/parser/NodeConstructors.h', u'Source/JavaScriptCore/parser/Nodes.h', u'Source/JavaScriptCore/parser/Parser.cpp', u'Source/JavaScriptCore/parser/ResultType.h', u'Source/JavaScriptCore/runtime/JSCJSValueInlines.h', u'Source/JavaScriptCore/runtime/JSCell.h', u'Source/JavaScriptCore/runtime/JSCellInlines.h', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/TriState.h']" exit_code: 1
Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:1054:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:1056:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:1058:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 3 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Geoffrey Garen 2013-04-23 15:17:05 PDT 
Committed r148999: <http://trac.webkit.org/changeset/148999>
Comment 5 Filip Pizlo 2013-04-25 17:23:54 PDT 
This broke http://kripken.github.io/ammo.js/examples/new/ammo.html
Comment 6 Filip Pizlo 2013-04-25 17:32:59 PDT 
Reopening because it broke things.
Comment 7 Filip Pizlo 2013-04-25 17:39:33 PDT 
Rolled out in http://trac.webkit.org/changeset/149158
Comment 8 Geoffrey Garen 2013-04-26 23:42:25 PDT 
Committed r149236: <http://trac.webkit.org/changeset/149236>