RESOLVED FIXED 115057
Filled out more cases of branch folding in bytecode when emitting expressions into a branching context 
https://bugs.webkit.org/show_bug.cgi?id=115057
Summary Filled out more cases of branch folding in bytecode when emitting expressions...
Geoffrey Garen
Reported 2013-04-23 14:08:02 PDT
Filled out more cases of branch folding in bytecode when emitting expressions into a branching context
Attachments
Patch (36.04 KB, patch)
2013-04-23 14:40 PDT, Geoffrey Garen 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2013-04-23 14:40:18 PDT
Created attachment 199328 [details] Patch
Filip Pizlo
Comment 2 2013-04-23 14:42:49 PDT
Comment on attachment 199328 [details] Patch Cool!
WebKit Commit Bot
Comment 3 2013-04-23 14:47:39 PDT
Attachment 199328 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/js/regress/branch-fold-expected.txt', u'LayoutTests/fast/js/regress/branch-fold.html', u'LayoutTests/fast/js/regress/script-tests/branch-fold.js', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/JavaScriptCore.order', u'Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp', u'Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h', u'Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp', u'Source/JavaScriptCore/parser/ASTBuilder.h', u'Source/JavaScriptCore/parser/NodeConstructors.h', u'Source/JavaScriptCore/parser/Nodes.h', u'Source/JavaScriptCore/parser/Parser.cpp', u'Source/JavaScriptCore/parser/ResultType.h', u'Source/JavaScriptCore/runtime/JSCJSValueInlines.h', u'Source/JavaScriptCore/runtime/JSCell.h', u'Source/JavaScriptCore/runtime/JSCellInlines.h', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/TriState.h']" exit_code: 1 Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:1054: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:1056: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:1058: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 3 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 4 2013-04-23 15:17:05 PDT
Committed r148999: <http://trac.webkit.org/changeset/148999>
Filip Pizlo
Comment 5 2013-04-25 17:23:54 PDT
This broke http://kripken.github.io/ammo.js/examples/new/ammo.html
Filip Pizlo
Comment 6 2013-04-25 17:32:59 PDT
Reopening because it broke things.
Filip Pizlo
Comment 7 2013-04-25 17:39:33 PDT
Rolled out in http://trac.webkit.org/changeset/149158
Geoffrey Garen
Comment 8 2013-04-26 23:42:25 PDT
Committed r149236: <http://trac.webkit.org/changeset/149236>
Note You need to log in before you can comment on or make changes to this bug.