Bug 115032 – [GStreamer] Add audio/speex MIME type as supported

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adrian Perez]

[GStreamer] Add audio/speex MIME type as supported

[Adrian Perez]

GStreamer has support for the Speex codec (http://www.speex.org).
Speex streams may be embedded in a Ogg container, or standalone.
The case of the Ogg container is already covered by the “*/ogg”
MIME types declared as supported by the GStreamer media playing
code, but for standalone streams to work, “audio/speex” has to
be added. Also, it would be desirable to have a check in the
media tests.

[Adrian Perez]

Created attachment 199226 [details]
Patch

[Adrian Perez]

The patch is similar to the one that was accepted a while ago for
bug #98759

[Philippe Normand]

Comment on attachment 199226 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199226&action=review

> LayoutTests/platform/qt-linux/media/media-can-play-ogg-expected.txt:9
> +EXPECTED (video.canPlayType('audio/ogg; codecs=speex') == 'probably'), OBSERVED '' FAIL

Hum are you sure about this one? AFAIK qt-linux uses the GStreamer backend so this result would be OK instead of FAIL

[Adrian Perez]

(In reply to comment #4)
> (From update of attachment 199226 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=199226&action=review
> 
> > LayoutTests/platform/qt-linux/media/media-can-play-ogg-expected.txt:9
> > +EXPECTED (video.canPlayType('audio/ogg; codecs=speex') == 'probably'), OBSERVED '' FAIL
> 
> Hum are you sure about this one? AFAIK qt-linux uses the GStreamer backend so this result would be OK instead of FAIL

I have double-checked: in the Opus case it was left as FAIL because the
qt-linux bots do not have a gst-plugins-bad (or not recent enough), but
I see that the Speex element is in gst-plugins-good, so I am updating the
patch leaving this as OK for qt-linux.

[Adrian Perez]

Created attachment 199630 [details]
Patch

[Adrian Perez]

Adding Xan in CC.

Xan, could you please cq+ the patch?

[Philippe Normand]

Comment on attachment 199630 [details]
Patch

Sorry I forgot to set it

[WebKit Commit Bot]

Comment on attachment 199630 [details]
Patch

Clearing flags on attachment: 199630

Committed r149111: <http://trac.webkit.org/changeset/149111>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.