Bug 115018 - PDFPlugin: Cursor should become an i-beam when over selectable text
Summary: PDFPlugin: Cursor should become an i-beam when over selectable text
Alias: None
Product: WebKit
Classification: Unclassified
Component: PDF (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
Keywords: InRadar
Depends on:
Reported: 2013-04-23 00:25 PDT by Tim Horton
Modified: 2013-04-24 22:30 PDT (History)
1 user (show)

See Also:

patch (4.93 KB, patch)
2013-04-23 00:25 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
better patch (7.58 KB, patch)
2013-04-23 13:26 PDT, Tim Horton
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-04-23 00:25:10 PDT

I'd love a way to do this without IPC every mouse-move, but that would require getting reliable mouse-enter events (so that I could cache the last cursor and bail if it hasn't changed, unless this is the first mouse-move since the plugin has been entered), which I'm not yet sure how to do.
Comment 1 Tim Horton 2013-04-23 00:25:58 PDT
Created attachment 199163 [details]
Comment 2 Alexey Proskuryakov 2013-04-23 09:34:48 PDT
Comment on attachment 199163 [details]

It feels wrong to send a message on every MouseMove event. Unsure what to suggest though.
Comment 3 Tim Horton 2013-04-23 13:26:37 PDT
Created attachment 199321 [details]
better patch
Comment 4 Tim Horton 2013-04-23 13:27:00 PDT
Comment on attachment 199321 [details]
better patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199321&action=review

> Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.h:35
> +#include <WebCore/Cursor.h>

Don't need this anymore.
Comment 5 Tim Horton 2013-04-24 22:30:00 PDT