Bug 115009 - Remove unused code of RefCounted after chromium removal
Summary: Remove unused code of RefCounted after chromium removal
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-22 20:26 PDT by Benjamin Poulain
Modified: 2013-04-23 12:27 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.70 KB, patch)
2013-04-22 20:29 PDT, Benjamin Poulain 		rniwa: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (600.67 KB, application/zip)
2013-04-22 23:45 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2013-04-22 20:26:12 PDT 
Remove unused code of RefCounted after chromium removal
Comment 1 Benjamin Poulain 2013-04-22 20:29:35 PDT 
Created attachment 199140 [details]
Patch
Comment 2 Build Bot 2013-04-22 23:44:58 PDT 
Comment on attachment 199140 [details]
Patch

Attachment 199140 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/141661

New failing tests:
svg/custom/getscreenctm-in-scrollable-svg-area.xhtml
svg/custom/getscreenctm-in-scrollable-div-area.xhtml
svg/custom/getscreenctm-in-scrollable-div-area-nested.xhtml
Comment 3 Build Bot 2013-04-22 23:45:00 PDT 
Created attachment 199157 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2
Comment 4 Alexey Proskuryakov 2013-04-22 23:47:15 PDT 
There is an ASSERT(m_refCount > 0) in this file, please update it accordingly.
Comment 5 Ryosuke Niwa 2013-04-22 23:49:09 PDT 
(In reply to comment #4)
> There is an ASSERT(m_refCount > 0) in this file, please update it accordingly.

Oh, you mean to ASSERT(m_refCount)?
Comment 6 Benjamin Poulain 2013-04-23 12:24:31 PDT 
(In reply to comment #4)
> There is an ASSERT(m_refCount > 0) in this file, please update it accordingly.

That was intentional, in my opinion ASSERT(m_refCount > 0) makes more sense. But I don't mind changing it.
Comment 7 Benjamin Poulain 2013-04-23 12:27:45 PDT 
Committed r148981: <http://trac.webkit.org/changeset/148981>