Bug 115004 - Change approach to third-party blocking for LocalStorage
Summary: Change approach to third-party blocking for LocalStorage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Vicki Pfau
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-04-22 18:00 PDT by Vicki Pfau
Modified: 2016-06-20 11:56 PDT (History)
6 users (show)

See Also:


Attachments
Patch (14.31 KB, patch)
2013-04-22 18:12 PDT, Vicki Pfau
mjs: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (580.50 KB, application/zip)
2013-04-22 20:47 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Vicki Pfau 2013-04-22 18:00:01 PDT
The approach to blocking LocalStorage introduce in r125335 has broken many sites that either depend on LocalStorage sufficiently that disabling it has broken functionality, or sites that blindly try to access it without attempting to catch an exception. We need an approach that won't break sites like these.

<rdar://problem/13650298>
Comment 1 Vicki Pfau 2013-04-22 18:12:11 PDT
Created attachment 199134 [details]
Patch
Comment 2 Build Bot 2013-04-22 20:47:48 PDT
Comment on attachment 199134 [details]
Patch

Attachment 199134 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/199351

New failing tests:
http/tests/security/cross-origin-local-storage-wk1.html
Comment 3 Build Bot 2013-04-22 20:47:49 PDT
Created attachment 199142 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2
Comment 4 Vicki Pfau 2013-04-23 11:24:17 PDT
Looks like I neglected to rebaseline a test on platforms other that mac (including mac-wk2). It looks like it's producing the right result, though, so I'd just need to land a patch with the rebaselined results--there's no code change from the patch I previously uploaded.
Comment 5 Maciej Stachowiak 2013-04-29 14:30:25 PDT
Comment on attachment 199134 [details]
Patch

r=me but don't forget to fix the wk2 results.
Comment 6 Vicki Pfau 2013-04-29 15:43:56 PDT
Committed r149326: <http://trac.webkit.org/changeset/149326>