Bug 114996 – Remove the Chromium-specific helper from run_webkit_tests.py

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Seokju Kwon]

$./Tools/Scripts/run-webkit-tests --help

  Chromium-specific Options:
    --nocheck-sys-deps  Don't check the system dependencies (themes)
    --adb-device=ADB_DEVICE
                        Run Android layout tests on these devices.

[Seokju Kwon]

Created attachment 199123 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 199123 [details]
Patch

Rejecting attachment 199123 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
 manager.run(args)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 191, in run
    if not self._set_up_run(tests_to_run):
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 156, in _set_up_run
    if not self._options.nocheck_sys_deps:
AttributeError: Values instance has no attribute 'nocheck_sys_deps'
Failed to execute Tools/Scripts/new-run-webkit-tests at Tools/Scripts/run-webkit-tests line 106.

Full output: http://webkit-queues.appspot.com/results/118339

[Seokju Kwon]

Created attachment 199135 [details]
Patch

[Seokju Kwon]

dpranke : What do you think about 2nd patch?

[WebKit Commit Bot]

Comment on attachment 199135 [details]
Patch

Clearing flags on attachment: 199135

Committed r149046: <http://trac.webkit.org/changeset/149046>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.