Bug 114988 - [Flakiness Dashboard] Update expected outcome in a couple of unit tests after r148778
Summary: [Flakiness Dashboard] Update expected outcome in a couple of unit tests after...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-22 13:12 PDT by Zan Dobersek
Modified: 2013-05-06 10:49 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.94 KB, patch)
2013-04-22 13:42 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (7.76 KB, patch)
2013-04-22 13:43 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (3.38 KB, patch)
2013-04-22 13:44 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (3.35 KB, patch)
2013-04-22 14:01 PDT, Zan Dobersek 		rniwa: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-04-22 13:12:07 PDT 
[Dashboard] Update expected outcome in a couple of unit tests after r148778
Comment 1 Zan Dobersek 2013-04-22 13:42:20 PDT 
Created attachment 199098 [details]
Patch
Comment 2 Zan Dobersek 2013-04-22 13:43:16 PDT 
Created attachment 199099 [details]
Patch
Comment 3 Zan Dobersek 2013-04-22 13:44:23 PDT 
Created attachment 199100 [details]
Patch
Comment 4 Zan Dobersek 2013-04-22 14:01:39 PDT 
Created attachment 199108 [details]
Patch
Comment 5 Ryosuke Niwa 2013-05-06 09:56:08 PDT 
Comment on attachment 199108 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199108&action=review

> Tools/ChangeLog:3
> +        [Dashboard] Update expected outcome in a couple of unit tests after r148778

s/Dashboard/Flakiness Dashboard/.

> Tools/TestResultServer/static-dashboards/loader_unittests.js:86
> -        "mac", "mac-lion", "mac-snowleopard", "qt", "win", "wk2"];
> +        "mac", "mac-lion", "mac-wk2", "mac-wk2", "qt", "win", "wk2"];

Why is mac-wk2 repeated twice?
Comment 6 Zan Dobersek 2013-05-06 10:17:02 PDT 
Comment on attachment 199108 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199108&action=review

>> Tools/TestResultServer/static-dashboards/loader_unittests.js:86
>> +        "mac", "mac-lion", "mac-wk2", "mac-wk2", "qt", "win", "wk2"];
> 
> Why is mac-wk2 repeated twice?

This is due to both the APPLE_MAC_LION_WK2 and APPLE_MAC_MOUNTAINLION_WK2 using the mac-wk2 expectations directory.
http://trac.webkit.org/browser/trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js#L42

The expectations files are loaded per platform so that when loaded, they can be parsed and properly assigned to the appropriate platform. This is done in Loader._loadExpectationsFiles.
http://trac.webkit.org/browser/trunk/Tools/TestResultServer/static-dashboards/loader.js#L232
Comment 7 Zan Dobersek 2013-05-06 10:49:22 PDT 
Committed r149610: <http://trac.webkit.org/changeset/149610>