Bug 114988 – [Flakiness Dashboard] Update expected outcome in a couple of unit tests after r148778

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Zan Dobersek]

[Dashboard] Update expected outcome in a couple of unit tests after r148778

[Zan Dobersek]

Created attachment 199098 [details]
Patch

[Zan Dobersek]

Created attachment 199099 [details]
Patch

[Zan Dobersek]

Created attachment 199100 [details]
Patch

[Zan Dobersek]

Created attachment 199108 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 199108 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199108&action=review

> Tools/ChangeLog:3
> +        [Dashboard] Update expected outcome in a couple of unit tests after r148778

s/Dashboard/Flakiness Dashboard/.

> Tools/TestResultServer/static-dashboards/loader_unittests.js:86
> -        "mac", "mac-lion", "mac-snowleopard", "qt", "win", "wk2"];
> +        "mac", "mac-lion", "mac-wk2", "mac-wk2", "qt", "win", "wk2"];

Why is mac-wk2 repeated twice?

[Zan Dobersek]

Comment on attachment 199108 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199108&action=review

>> Tools/TestResultServer/static-dashboards/loader_unittests.js:86
>> +        "mac", "mac-lion", "mac-wk2", "mac-wk2", "qt", "win", "wk2"];
> 
> Why is mac-wk2 repeated twice?

This is due to both the APPLE_MAC_LION_WK2 and APPLE_MAC_MOUNTAINLION_WK2 using the mac-wk2 expectations directory.
http://trac.webkit.org/browser/trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js#L42

The expectations files are loaded per platform so that when loaded, they can be parsed and properly assigned to the appropriate platform. This is done in Loader._loadExpectationsFiles.
http://trac.webkit.org/browser/trunk/Tools/TestResultServer/static-dashboards/loader.js#L232

[Zan Dobersek]

Committed r149610: <http://trac.webkit.org/changeset/149610>