Bug 114982 - Web Inspector: InspectorCSSAgent::SetPropertyTextAction has a bad mergeId
Summary: Web Inspector: InspectorCSSAgent::SetPropertyTextAction has a bad mergeId
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 116924
  Show dependency treegraph
 
Reported: 2013-04-22 12:23 PDT by Timothy Hatcher
Modified: 2017-01-18 23:42 PST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2013-04-22 12:23:50 PDT
The mergeId for InspectorCSSAgent::SetPropertyTextAction is:

        String::format("SetPropertyText %s:%u:%s", m_styleSheet->id().utf8().data(), m_propertyIndex, m_overwrite ? "true" : "false");

But if you have two properties from different rules but the same index those would merge if edited back to back. We should include m_cssId.ordinal() in there.
Comment 1 Timothy Hatcher 2014-01-10 15:37:12 PST
Moving to the right component.
Comment 2 Radar WebKit Bug Importer 2014-01-10 15:37:26 PST
<rdar://problem/15796837>