Bug 114965 – [Mac] HEAD requests changed to GET after 301, 302, and 303 redirections (http/tests/xmlhttprequest/head-redirection.html)

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Jessie Berlin]

This was fixed for GTK and EFL in http://trac.webkit.org/changeset/147914 for https://bugs.webkit.org/show_bug.cgi?id=110127, but still needs to be fixed for Mac.

[Radar WebKit Bug Importer]

<rdar://problem/13706454>

[Alexey Proskuryakov]

See also: bug 46183.

[Rob Buis]

Created attachment 356168 [details]
Patch

[EWS Watchlist]

Comment on attachment 356168 [details]
Patch

Attachment 356168 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/10213178

New failing tests:
imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method-worker.html
imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method.html
http/tests/xmlhttprequest/head-redirection.html

[EWS Watchlist]

Created attachment 356169 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Rob Buis]

Created attachment 356175 [details]
Patch

[EWS Watchlist]

Comment on attachment 356175 [details]
Patch

Attachment 356175 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/10214966

New failing tests:
http/tests/xmlhttprequest/head-redirection.html
imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method.html
imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method-worker.html

[EWS Watchlist]

Created attachment 356181 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 356175 [details]
Patch

Attachment 356175 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/10215039

New failing tests:
http/tests/xmlhttprequest/head-redirection.html

[EWS Watchlist]

Created attachment 356186 [details]
Archive of layout-test-results from ews115 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Rob Buis]

Created attachment 356199 [details]
Patch

[Rob Buis]

Created attachment 356233 [details]
Patch

[Frédéric Wang (:fredw)]

Comment on attachment 356233 [details]
Patch

This LGTM but maybe people who were involved in bug 110127 should take a look ;-)

[youenn fablet]

This behavior is HTTP generic and not browser specific.
I would believe CFNetwork should do the right thing for us.
If they cannot, then we can go on with this patch.

[Rob Buis]

> I would believe CFNetwork should do the right thing for us.

Do you know if there is an existing bug filed against CFNetwork to not change the HEAD requests into GET?

[Rob Buis]

>> I would believe CFNetwork should do the right thing for us.

>Do you know if there is an existing bug filed against CFNetwork to not change the HEAD requests into GET?

I realize you probably can't comment. An alternative could be to go with the patch but add a "FIXME: remove when CFNetwork changes/fixes behavior". WDYT?

[Frédéric Wang (:fredw)]

(In reply to Rob Buis from comment #16)
> >> I would believe CFNetwork should do the right thing for us.
> 
> >Do you know if there is an existing bug filed against CFNetwork to not change the HEAD requests into GET?
> 
> I realize you probably can't comment. An alternative could be to go with the
> patch but add a "FIXME: remove when CFNetwork changes/fixes behavior". WDYT?

I guess even FIXME(rdar://problem/13706454)

[youenn fablet]

(In reply to Frédéric Wang (:fredw) from comment #17)
> (In reply to Rob Buis from comment #16)
> > >> I would believe CFNetwork should do the right thing for us.
> > 
> > >Do you know if there is an existing bug filed against CFNetwork to not change the HEAD requests into GET?
> > 
> > I realize you probably can't comment. An alternative could be to go with the
> > patch but add a "FIXME: remove when CFNetwork changes/fixes behavior". WDYT?
> 
> I guess even FIXME(rdar://problem/13706454)

Let's do that for now.

[Rob Buis]

Created attachment 356593 [details]
Patch

[Rob Buis]

Comment on attachment 356593 [details]
Patch

I added the FIXME.

[WebKit Commit Bot]

Comment on attachment 356593 [details]
Patch

Clearing flags on attachment: 356593

Committed r238891: <https://trac.webkit.org/changeset/238891>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.