Bug 114965 - [Mac] HEAD requests changed to GET after 301, 302, and 303 redirections (http/tests/xmlhttprequest/head-redirection.html)
Summary: [Mac] HEAD requests changed to GET after 301, 302, and 303 redirections (http...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-04-22 10:12 PDT by Jessie Berlin
Modified: 2018-12-05 03:11 PST (History)
12 users (show)

See Also:


Attachments
Patch (1.83 KB, patch)
2018-11-30 03:24 PST, Rob Buis
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-sierra-wk2 (3.18 MB, application/zip)
2018-11-30 04:35 PST, EWS Watchlist
no flags Details
Patch (6.87 KB, patch)
2018-11-30 07:31 PST, Rob Buis
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-sierra (2.43 MB, application/zip)
2018-11-30 08:35 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews115 for mac-sierra (2.00 MB, application/zip)
2018-11-30 09:28 PST, EWS Watchlist
no flags Details
Patch (8.61 KB, patch)
2018-11-30 10:59 PST, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (9.80 KB, patch)
2018-11-30 14:05 PST, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (9.84 KB, patch)
2018-12-05 02:24 PST, Rob Buis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jessie Berlin 2013-04-22 10:12:20 PDT
This was fixed for GTK and EFL in http://trac.webkit.org/changeset/147914 for https://bugs.webkit.org/show_bug.cgi?id=110127, but still needs to be fixed for Mac.
Comment 1 Radar WebKit Bug Importer 2013-04-22 10:12:32 PDT
<rdar://problem/13706454>
Comment 2 Alexey Proskuryakov 2013-04-23 13:37:24 PDT
See also: bug 46183.
Comment 3 Rob Buis 2018-11-30 03:24:17 PST
Created attachment 356168 [details]
Patch
Comment 4 EWS Watchlist 2018-11-30 04:35:55 PST
Comment on attachment 356168 [details]
Patch

Attachment 356168 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/10213178

New failing tests:
imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method-worker.html
imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method.html
http/tests/xmlhttprequest/head-redirection.html
Comment 5 EWS Watchlist 2018-11-30 04:35:56 PST
Created attachment 356169 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 6 Rob Buis 2018-11-30 07:31:56 PST
Created attachment 356175 [details]
Patch
Comment 7 EWS Watchlist 2018-11-30 08:35:22 PST
Comment on attachment 356175 [details]
Patch

Attachment 356175 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/10214966

New failing tests:
http/tests/xmlhttprequest/head-redirection.html
imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method.html
imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method-worker.html
Comment 8 EWS Watchlist 2018-11-30 08:35:24 PST
Created attachment 356181 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 9 EWS Watchlist 2018-11-30 09:28:04 PST
Comment on attachment 356175 [details]
Patch

Attachment 356175 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/10215039

New failing tests:
http/tests/xmlhttprequest/head-redirection.html
Comment 10 EWS Watchlist 2018-11-30 09:28:05 PST
Created attachment 356186 [details]
Archive of layout-test-results from ews115 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 11 Rob Buis 2018-11-30 10:59:00 PST
Created attachment 356199 [details]
Patch
Comment 12 Rob Buis 2018-11-30 14:05:35 PST
Created attachment 356233 [details]
Patch
Comment 13 Frédéric Wang (:fredw) 2018-12-04 07:55:23 PST
Comment on attachment 356233 [details]
Patch

This LGTM but maybe people who were involved in bug 110127 should take a look ;-)
Comment 14 youenn fablet 2018-12-04 08:36:11 PST
This behavior is HTTP generic and not browser specific.
I would believe CFNetwork should do the right thing for us.
If they cannot, then we can go on with this patch.
Comment 15 Rob Buis 2018-12-04 09:03:26 PST
> I would believe CFNetwork should do the right thing for us.

Do you know if there is an existing bug filed against CFNetwork to not change the HEAD requests into GET?
Comment 16 Rob Buis 2018-12-04 09:09:19 PST
>> I would believe CFNetwork should do the right thing for us.

>Do you know if there is an existing bug filed against CFNetwork to not change the HEAD requests into GET?

I realize you probably can't comment. An alternative could be to go with the patch but add a "FIXME: remove when CFNetwork changes/fixes behavior". WDYT?
Comment 17 Frédéric Wang (:fredw) 2018-12-04 09:18:16 PST
(In reply to Rob Buis from comment #16)
> >> I would believe CFNetwork should do the right thing for us.
> 
> >Do you know if there is an existing bug filed against CFNetwork to not change the HEAD requests into GET?
> 
> I realize you probably can't comment. An alternative could be to go with the
> patch but add a "FIXME: remove when CFNetwork changes/fixes behavior". WDYT?

I guess even FIXME(rdar://problem/13706454)
Comment 18 youenn fablet 2018-12-04 10:36:07 PST
(In reply to Frédéric Wang (:fredw) from comment #17)
> (In reply to Rob Buis from comment #16)
> > >> I would believe CFNetwork should do the right thing for us.
> > 
> > >Do you know if there is an existing bug filed against CFNetwork to not change the HEAD requests into GET?
> > 
> > I realize you probably can't comment. An alternative could be to go with the
> > patch but add a "FIXME: remove when CFNetwork changes/fixes behavior". WDYT?
> 
> I guess even FIXME(rdar://problem/13706454)

Let's do that for now.
Comment 19 Rob Buis 2018-12-05 02:24:59 PST
Created attachment 356593 [details]
Patch
Comment 20 Rob Buis 2018-12-05 02:33:07 PST
Comment on attachment 356593 [details]
Patch

I added the FIXME.
Comment 21 WebKit Commit Bot 2018-12-05 03:11:05 PST
Comment on attachment 356593 [details]
Patch

Clearing flags on attachment: 356593

Committed r238891: <https://trac.webkit.org/changeset/238891>
Comment 22 WebKit Commit Bot 2018-12-05 03:11:07 PST
All reviewed patches have been landed.  Closing bug.