Bug 114962 - Cancelling load may cause deadlock in -[AVPlayerItem release]
Summary: Cancelling load may cause deadlock in -[AVPlayerItem release]
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-22 09:06 PDT by Jer Noble
Modified: 2013-04-22 13:02 PDT (History)
1 user (show)

See Also:


Attachments
Patch (3.29 KB, patch)
2013-04-22 11:26 PDT, Jer Noble
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2013-04-22 09:06:05 PDT
Cancelling load may cause deadlock in -[AVPlayerItem release]
Comment 1 Jer Noble 2013-04-22 11:26:29 PDT
Created attachment 199051 [details]
Patch
Comment 2 Eric Carlson 2013-04-22 11:42:11 PDT
Comment on attachment 199051 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199051&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:1627
> +        if (!m_callback->shouldWaitForLoadingOfResource(loadingRequest))

This should check to make sure m_callback is not NULL.
Comment 3 Jer Noble 2013-04-22 12:17:26 PDT
<rdar://problem/13706310>
Comment 4 Jer Noble 2013-04-22 13:02:06 PDT
Committed r148906: <http://trac.webkit.org/changeset/148906>