Bug 114957 - [Flakiness Dashboard] Simplify builder-name-based platform recognition
Summary: [Flakiness Dashboard] Simplify builder-name-based platform recognition
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks: 114971
  Show dependency treegraph
 
Reported: 2013-04-22 07:10 PDT by Zan Dobersek
Modified: 2013-05-06 10:32 PDT (History)
2 users (show)

See Also:


Attachments
Patch (7.72 KB, patch)
2013-04-22 14:00 PDT, Zan Dobersek
rniwa: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-04-22 07:10:16 PDT
[Dashboard] Simplify builder-name-based platform recognition
Comment 1 Zan Dobersek 2013-04-22 14:00:07 PDT
Created attachment 199105 [details]
Patch
Comment 2 Ryosuke Niwa 2013-05-06 09:49:41 PDT
Comment on attachment 199105 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199105&action=review

> Tools/ChangeLog:3
> +        [Dashboard] Simplify builder-name-based platform recognition

s/Dashboard/Flakiness Dashboard/.

> Tools/TestResultServer/static-dashboards/flakiness_dashboard.js:360
> +function determineBuilderPlatform(builderNameUpperCase)

We should get rid of SnowLeopard and add MountainLion.
Comment 3 Zan Dobersek 2013-05-06 10:32:02 PDT
Committed r149604: <http://trac.webkit.org/changeset/149604>
Comment 4 Zan Dobersek 2013-05-06 10:32:31 PDT
Comment on attachment 199105 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199105&action=review

>> Tools/TestResultServer/static-dashboards/flakiness_dashboard.js:360
>> +function determineBuilderPlatform(builderNameUpperCase)
> 
> We should get rid of SnowLeopard and add MountainLion.

Will address in a follow-up patch.