The following methods are already defined in DOMFileSystemBlackBerry.cpp: crackFileSystemURL() createFileSystemURL() isValidType() supportsToURL()
Created attachment 199017 [details] Patch
Comment on attachment 199017 [details] Patch OK.
Comment on attachment 199017 [details] Patch Clearing flags on attachment: 199017 Committed r149034: <http://trac.webkit.org/changeset/149034>
All reviewed patches have been landed. Closing bug.
What The Fuck? This should have: -Justification on why you did not make an abstraction instead. -Justification for using different implementation. Adding platform #ifdef anywhere at random places in WebCore is not okay, we are trying to remove them. Please explain.
(In reply to comment #5) > What The Fuck? > > This should have: > -Justification on why you did not make an abstraction instead. > -Justification for using different implementation. > > Adding platform #ifdef anywhere at random places in WebCore is not okay, we are trying to remove them. Please explain. The file already had #ifdefs for Chromium, which were removed recently with the removal of the Chromium code. It just so happens that the BB port was also using this feature, but the #ifdefs were not upstreamed. So the justification is that in general adding an extra #ifdef when there's already one is not a big deal, but we can open another bug to improve the code.
(In reply to comment #5) > -Justification for using different implementation. Apart from what Xan said, I'll try to see if we can merge both implementations now that there's no Chromium code around.
This has landed last week, there is no chromium code anymore. Even when chromium was there, they were doing a ton more maintenance than (In reply to comment #7) > (In reply to comment #5) > > -Justification for using different implementation. > > Apart from what Xan said, I'll try to see if we can merge both > implementations now that there's no Chromium code around. Thanks. That is the right thing to do.