RESOLVED FIXED 114942
[BlackBerry] Need to send out change event for date/color picker 
https://bugs.webkit.org/show_bug.cgi?id=114942
Summary [BlackBerry] Need to send out change event for date/color picker
Charles Wei
Reported 2013-04-22 02:18:58 PDT
For now the date/time/color are implemented with PagePopups, when the user finishes selection and closes the popup, we set the value to the element but there's no change event sent out. so the javascript can't get the change event to perform its work if the application registers change handler. We need to instruct the webkit to send out 'change' event when the user selection changes. Internal tracking No. : 326167
Attachments
Patch (2.35 KB, patch)
2013-04-22 02:46 PDT, Charles Wei 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Charles Wei
Comment 1 2013-04-22 02:46:58 PDT
Created attachment 199011 [details] Patch
Mike Fenton
Comment 2 2013-04-22 07:56:48 PDT
Looks good, but do we need it for select as well? void InputHandler::setInputValue(const WTF::String& value) would be the place if it's required.
Charles Wei
Comment 3 2013-04-22 18:10:16 PDT
(In reply to comment #2) > Looks good, but do we need it for select as well? > > void InputHandler::setInputValue(const WTF::String& value) would be the place if it's required. No, we don't . Selection change is already taken care of in SelectPopupClient::notifySelectionChange() which in turn calls : m_element->dispatchFormControlChangeEvent(); to send out the change event.
Carlos Garcia Campos
Comment 4 2013-04-23 00:05:06 PDT
Comment on attachment 199011 [details] Patch It makes sense.
WebKit Commit Bot
Comment 5 2013-04-23 04:57:10 PDT
Comment on attachment 199011 [details] Patch Clearing flags on attachment: 199011 Committed r148959: <http://trac.webkit.org/changeset/148959>
WebKit Commit Bot
Comment 6 2013-04-23 04:57:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.