Bug 114941 - Scrollbar should not depend on EventHandler, Frame and FrameView
Summary: Scrollbar should not depend on EventHandler, Frame and FrameView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 21354
  Show dependency treegraph
 
Reported: 2013-04-22 02:08 PDT by Carlos Garcia Campos
Modified: 2013-04-22 10:01 PDT (History)
1 user (show)

See Also:


Attachments
Patch (2.53 KB, patch)
2013-04-22 02:13 PDT, Carlos Garcia Campos
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2013-04-22 02:08:24 PDT
It's a layering violation.
Comment 1 Carlos Garcia Campos 2013-04-22 02:13:53 PDT
Created attachment 199006 [details]
Patch
Comment 2 Darin Adler 2013-04-22 08:43:04 PDT
Comment on attachment 199006 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199006&action=review

> Source/WebCore/ChangeLog:14
> +        It's a layering violation that Scrollbar uses EventHandler, Frame
> +        and FrameView. Frame is used to get the EvenHandler that is used
> +        to set mousePressed to false after a Scrollbar::mouseUp(). This is
> +        not really needed, since EvenHandler already sets m_mousePressed
> +        to false when calling Scrollbar::mouseUp(). The PopupMenu windows
> +        implementation also calls Scrollbar::mouseUp(), but that scrollbar
> +        is not inside a FrameView.

Some EvenHandler typos here.
Comment 3 Carlos Garcia Campos 2013-04-22 08:50:32 PDT
(In reply to comment #2)
> (From update of attachment 199006 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=199006&action=review
> 
> > Source/WebCore/ChangeLog:14
> > +        It's a layering violation that Scrollbar uses EventHandler, Frame
> > +        and FrameView. Frame is used to get the EvenHandler that is used
> > +        to set mousePressed to false after a Scrollbar::mouseUp(). This is
> > +        not really needed, since EvenHandler already sets m_mousePressed
> > +        to false when calling Scrollbar::mouseUp(). The PopupMenu windows
> > +        implementation also calls Scrollbar::mouseUp(), but that scrollbar
> > +        is not inside a FrameView.
> 
> Some EvenHandler typos here.

Ooops, will fix them before landing, thanks for the review.
Comment 4 Carlos Garcia Campos 2013-04-22 10:01:28 PDT
Committed r148892: <http://trac.webkit.org/changeset/148892>