Bug 114898 - Improve StringImpl code density for older ARM hardware
Summary: Improve StringImpl code density for older ARM hardware
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-04-19 23:25 PDT by Benjamin Poulain
Modified: 2013-04-21 23:20 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.71 KB, patch)
2013-04-19 23:30 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (4.16 KB, patch)
2013-04-20 00:47 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (4.82 KB, patch)
2013-04-20 01:16 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (8.12 KB, patch)
2013-04-20 19:37 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2013-04-19 23:25:28 PDT 
Improve StringImpl code density for older ARM hardware
Comment 1 Benjamin Poulain 2013-04-19 23:30:07 PDT 
Created attachment 198929 [details]
Patch
Comment 2 Benjamin Poulain 2013-04-19 23:30:49 PDT 
Bug <rdar://problem/13700356>
Comment 3 Build Bot 2013-04-20 00:04:04 PDT 
Comment on attachment 198929 [details]
Patch

Attachment 198929 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/15455
Comment 4 Benjamin Poulain 2013-04-20 00:47:55 PDT 
Created attachment 198932 [details]
Patch
Comment 5 Benjamin Poulain 2013-04-20 01:16:37 PDT 
Created attachment 198935 [details]
Patch
Comment 6 Build Bot 2013-04-20 02:01:21 PDT 
Comment on attachment 198935 [details]
Patch

Attachment 198935 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/186328
Comment 7 Geoffrey Garen 2013-04-20 16:25:55 PDT 
Comment on attachment 198935 [details]
Patch

r=me

You'll need to update the Windows export symbol before landing.
Comment 8 Geoffrey Garen 2013-04-20 16:26:35 PDT 
The required symbol name is: ??1StringImpl@WTF@@QAE@XZ.
Comment 9 Benjamin Poulain 2013-04-20 19:37:04 PDT 
Created attachment 198951 [details]
Patch
Comment 10 Benjamin Poulain 2013-04-21 23:20:06 PDT 
Comment on attachment 198951 [details]
Patch

Clearing flags on attachment: 198951

Committed r148857: <http://trac.webkit.org/changeset/148857>
Comment 11 Benjamin Poulain 2013-04-21 23:20:11 PDT 
All reviewed patches have been landed.  Closing bug.