Bug 114892 - [BlackBerry] Update BatteryClientBlackBerry to use our port's new listener interface
Summary: [BlackBerry] Update BatteryClientBlackBerry to use our port's new listener in...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-19 15:43 PDT by otcheung
Modified: 2013-04-22 08:42 PDT (History)
1 user (show)

See Also:


Attachments
Patch (5.79 KB, patch)
2013-04-19 15:49 PDT, otcheung
no flags Details | Formatted Diff | Diff
Patch (5.81 KB, patch)
2013-04-19 16:00 PDT, otcheung
no flags Details | Formatted Diff | Diff
Patch (5.84 KB, patch)
2013-04-22 08:07 PDT, otcheung
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description otcheung 2013-04-19 15:43:49 PDT
^
Comment 1 otcheung 2013-04-19 15:49:35 PDT
Created attachment 198917 [details]
Patch
Comment 2 otcheung 2013-04-19 16:00:05 PDT
Created attachment 198919 [details]
Patch
Comment 3 Rob Buis 2013-04-22 08:05:51 PDT
Comment on attachment 198919 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198919&action=review

LGTM.

> Source/WebKit/blackberry/WebCoreSupport/BatteryClientBlackBerry.cpp:40
> +    m_isActive = true;

You can group these, no need to set m_isActive to true if you already know it is true.

> Source/WebKit/blackberry/WebCoreSupport/BatteryClientBlackBerry.cpp:47
> +    m_isActive = false;

Ditto.
Comment 4 otcheung 2013-04-22 08:07:15 PDT
Created attachment 199030 [details]
Patch
Comment 5 Rob Buis 2013-04-22 08:14:50 PDT
Comment on attachment 199030 [details]
Patch

Looks good.
Comment 6 WebKit Commit Bot 2013-04-22 08:42:48 PDT
Comment on attachment 199030 [details]
Patch

Clearing flags on attachment: 199030

Committed r148885: <http://trac.webkit.org/changeset/148885>
Comment 7 WebKit Commit Bot 2013-04-22 08:42:50 PDT
All reviewed patches have been landed.  Closing bug.