Bug 114887 - [BlackBerry] URL decode data: URLs before passing them to the platform media player
Summary: [BlackBerry] URL decode data: URLs before passing them to the platform media ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Griggs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-19 13:20 PDT by John Griggs
Modified: 2013-04-22 09:42 PDT (History)
1 user (show)

See Also:


Attachments
Patch (2.02 KB, patch)
2013-04-22 07:11 PDT, John Griggs
no flags Details | Formatted Diff | Diff
Patch - Fixed ChangeLog issues in previous patch (1.99 KB, patch)
2013-04-22 09:02 PDT, John Griggs
no flags Details | Formatted Diff | Diff
Patch - More ChangeLog fixes. (1.93 KB, patch)
2013-04-22 09:12 PDT, John Griggs
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Griggs 2013-04-19 13:20:30 PDT
decode URL escape sequences in data: URLs before passing them to the BlackBerry platform media player
Comment 1 John Griggs 2013-04-22 07:11:41 PDT
Created attachment 199025 [details]
Patch
Comment 2 Rob Buis 2013-04-22 08:51:48 PDT
Comment on attachment 199025 [details]
Patch

Ok.
Comment 3 WebKit Commit Bot 2013-04-22 08:52:43 PDT
Comment on attachment 199025 [details]
Patch

Rejecting attachment 199025 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--non-interactive', 199025, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Liam Quinn found in /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py.
/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/141468
Comment 4 John Griggs 2013-04-22 09:02:26 PDT
Created attachment 199037 [details]
Patch - Fixed ChangeLog issues in previous patch
Comment 5 John Griggs 2013-04-22 09:12:08 PDT
Created attachment 199038 [details]
Patch - More ChangeLog fixes.
Comment 6 Rob Buis 2013-04-22 09:14:01 PDT
Comment on attachment 199038 [details]
Patch - More ChangeLog fixes.

Ok.
Comment 7 WebKit Commit Bot 2013-04-22 09:42:49 PDT
Comment on attachment 199038 [details]
Patch - More ChangeLog fixes.

Clearing flags on attachment: 199038

Committed r148890: <http://trac.webkit.org/changeset/148890>
Comment 8 WebKit Commit Bot 2013-04-22 09:42:51 PDT
All reviewed patches have been landed.  Closing bug.