WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
114885
[BlackBerry] Find-on-page should do the scoping again when highlight policy changed
https://bugs.webkit.org/show_bug.cgi?id=114885
Summary
[BlackBerry] Find-on-page should do the scoping again when highlight policy c...
Andy Chen
Reported
2013-04-19 11:27:56 PDT
We only started a new scoping when search text is changed. We should do the scoping again when the highlight policy changed but text not changed, otherwise, we could lose the yellow markers. For example, call findString with highlightAllMatches = false, then call it again with highlightAllMatches = true.
Attachments
Patch
(3.11 KB, patch)
2013-04-19 12:11 PDT
,
Andy Chen
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Andy Chen
Comment 1
2013-04-19 12:11:48 PDT
Created
attachment 198908
[details]
Patch
Rob Buis
Comment 2
2013-04-19 13:01:38 PDT
Comment on
attachment 198908
[details]
Patch LGTM.
WebKit Commit Bot
Comment 3
2013-04-19 13:28:08 PDT
Comment on
attachment 198908
[details]
Patch Clearing flags on attachment: 198908 Committed
r148762
: <
http://trac.webkit.org/changeset/148762
>
WebKit Commit Bot
Comment 4
2013-04-19 13:28:10 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug