Bug 114861 - [BlackBerry] Add dummy implementations of DragData::droppedFileSystemId()
Summary: [BlackBerry] Add dummy implementations of DragData::droppedFileSystemId()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 111729
  Show dependency treegraph
 
Reported: 2013-04-19 02:24 PDT by Alberto Garcia
Modified: 2013-04-22 02:57 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.43 KB, patch)
2013-04-19 02:26 PDT, Alberto Garcia
cgarcia: review-
cgarcia: commit-queue-
Details | Formatted Diff | Diff
Patch (1.21 KB, patch)
2013-04-22 01:35 PDT, Alberto Garcia
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2013-04-19 02:24:30 PDT
AccessibilityController::accessibleElementById() is needed since r129308,
DragData::droppedFileSystemId() appeared in r120667
Comment 1 Alberto Garcia 2013-04-19 02:26:54 PDT
Created attachment 198828 [details]
Patch
Comment 2 Carlos Garcia Campos 2013-04-22 00:49:09 PDT
Comment on attachment 198828 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198828&action=review

> Source/WebCore/platform/blackberry/DragDataBlackBerry.cpp:99
> +String DragData::droppedFileSystemId() const
> +{
> +    notImplemented();
> +    return String();
> +}

This should be inside a #if ENABLE(FILE_SYSTEM) block.
Comment 3 Alberto Garcia 2013-04-22 01:30:11 PDT
Ok, I'll also split the patch in two.
Comment 4 Alberto Garcia 2013-04-22 01:35:54 PDT
Created attachment 198999 [details]
Patch
Comment 5 WebKit Commit Bot 2013-04-22 02:57:23 PDT
Comment on attachment 198999 [details]
Patch

Clearing flags on attachment: 198999

Committed r148870: <http://trac.webkit.org/changeset/148870>
Comment 6 WebKit Commit Bot 2013-04-22 02:57:25 PDT
All reviewed patches have been landed.  Closing bug.