Bug 114860 - [BlackBerry] Remove implementation of ContextMenu classes
Summary: [BlackBerry] Remove implementation of ContextMenu classes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 111729
  Show dependency tree / graph
 
Reported: 2013-04-19 02:16 PDT by Alberto Garcia
Modified: 2013-06-14 13:03 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.43 KB, patch)
2013-04-19 02:17 PDT, Alberto Garcia 		no flags Details | Formatted Diff | Diff
Patch (4.97 KB, patch)
2013-04-19 05:39 PDT, Alberto Garcia 		no flags Details | Formatted Diff | Diff
Patch (18.27 KB, patch)
2013-06-10 02:21 PDT, Alberto Garcia 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2013-04-19 02:16:54 PDT 
Although in the BlackBerry port a PlatformMenuDescription is actually a void*, the definition of the method should match that of the parent class.
Comment 1 Alberto Garcia 2013-04-19 02:17:53 PDT 
Created attachment 198827 [details]
Patch
Comment 2 Alberto Garcia 2013-04-19 02:35:16 PDT 
Comment on attachment 198827 [details]
Patch

This patch is actually incomplete, I'll upload a new one.
Comment 3 Alberto Garcia 2013-04-19 05:35:09 PDT 
Updating bug title since a few more changes are needed.
Comment 4 Alberto Garcia 2013-04-19 05:39:22 PDT 
Created attachment 198845 [details]
Patch
Comment 5 Alberto Garcia 2013-06-10 02:19:17 PDT 
We are finally not going to use this, so we can safely remove this code.
Comment 6 Alberto Garcia 2013-06-10 02:21:11 PDT 
Created attachment 204143 [details]
Patch
Comment 7 Rob Buis 2013-06-14 12:37:40 PDT 
Comment on attachment 204143 [details]
Patch

LGTM. Will obviously bring a small speedup in build time :)
Comment 8 WebKit Commit Bot 2013-06-14 13:03:01 PDT 
Comment on attachment 204143 [details]
Patch

Clearing flags on attachment: 204143

Committed r151603: <http://trac.webkit.org/changeset/151603>
Comment 9 WebKit Commit Bot 2013-06-14 13:03:05 PDT 
All reviewed patches have been landed.  Closing bug.