[EFL][WK2]: Fix WKViewClientWebProcessCallbacks WK2 API test
Created attachment 198799 [details] Patch Proposed patch
Comment on attachment 198799 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=198799&action=review Could we found another way to simulate a crash? maybe just send a signal since this is efl-specific test meaning that it runs on unix? > Tools/TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:-96 > - viewClient.webProcessCrashed = webProcessCrashed; that is removing the part of functionality that is to be tested.
(In reply to comment #2) > (From update of attachment 198799 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=198799&action=review > > Could we found another way to simulate a crash? maybe just send a signal since this is efl-specific test meaning that it runs on unix? I'm testing an approach using an InjectedBundle to simulate the crash, so that we will still be able to test the crash callback. I am going to upload it soon, once I finish testing.
Created attachment 199148 [details] Patch Updated patch using InjectedBundle
Comment on attachment 199148 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=199148&action=review Looks good! > Tools/TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp:47 > +void WKViewClientWebProcessCallbacksTest::didReceiveMessage(WKBundleRef bundle, WKStringRef messageName, WKTypeRef messageBody) bundle and messageBody can be omitted.
Created attachment 199225 [details] Patch Addressed Mikhail's comment.
Comment on attachment 199225 [details] Patch Attachment 199225 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/77252 New failing tests: fast/repaint/japanese-rl-selection-repaint-in-regions.html
Created attachment 199338 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2
(In reply to comment #8) > Created an attachment (id=199338) [details] > Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 > > The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. > Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2 Hmm. This does not seem to be related with the patch itself. @Mikhail: Do you have any more remarks on this patch?
Comment on attachment 199225 [details] Patch LGTM.
(In reply to comment #10) > (From update of attachment 199225 [details]) > LGTM. Thanks for your review. Do I need to get a r+ from a WK2 owner or something like that?
(In reply to comment #11) > (In reply to comment #10) > > (From update of attachment 199225 [details] [details]) > > LGTM. > > Thanks for your review. Do I need to get a r+ from a WK2 owner or something like that? yeah, I guess so.
(In reply to comment #12) > (In reply to comment #11) > > (In reply to comment #10) > > > (From update of attachment 199225 [details] [details] [details]) > > > LGTM. > > > > Thanks for your review. Do I need to get a r+ from a WK2 owner or something like that? > > yeah, I guess so. Alright.
Comment on attachment 199225 [details] Patch The king has reviewed :)
Comment on attachment 199225 [details] Patch Clearing flags on attachment: 199225 Committed r149045: <http://trac.webkit.org/changeset/149045>
All reviewed patches have been landed. Closing bug.