Bug 114844 – [BLACKBERRY]fixed debug broken from previous patch

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[xuefeiren]

Source/WebKit/blackberry/WebKitSupport/RenderQueue.cpp
-void RenderQueue::scrollZoomJobsCompleted(const TileIndexList&, TileIndexList* completedJobs, bool shouldBlit)
+void RenderQueue::scrollZoomJobsCompleted(const TileIndexList& outstandingJobs, TileIndexList* completedJobs, bool shouldBlit)
 {
     // Get rid of the completed list!
     ASSERT(outstandingJobs.isEmpty());


in previous patch, remove a useful parameter in debug build.
so now fix it.

[xuefeiren]

Created attachment 198787 [details]
fixed debug broken from previous patch

fixed debug broken from previous patch

[Benjamin Poulain]

Comment on attachment 198787 [details]
fixed debug broken from previous patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198787&action=review

> Source/WebKit/blackberry/ChangeLog:10
> +        add missing parameter in 
> +        Source/WebKit/blackberry/WebKitSupport/RenderQueue.cpp
> +        void RenderQueue::scrollZoomJobsCompleted

add -> Add

Remove those lines...

> Source/WebKit/blackberry/ChangeLog:13
> +        * WebKitSupport/RenderQueue.cpp:
> +        (BlackBerry::WebKit::RenderQueue::scrollZoomJobsCompleted):

Add a short description here.

> Source/WebKit/blackberry/WebKitSupport/RenderQueue.cpp:885
>      ASSERT(outstandingJobs.isEmpty());

This should be ASSERT_UNUSED.

[xuefeiren]

Created attachment 198811 [details]
remove warning (unused parameter ) in platform/graphics/blackberry

remove warning (unused parameter ) in platform/graphics/blackberry

[xuefeiren]

Created attachment 198816 [details]
fixed debug broken from previous patch

add a parameter which was removed by mistake. now i need to fix it.

[xuefeiren]

(In reply to comment #2)

> This should be ASSERT_UNUSED.

it is used in ASSERT(), and i removed it in r148677 by mistake. And it broke the debug build,so now I need to add it back.

[xuefeiren]

Created attachment 198838 [details]
fixed debug broken from previous patch

fixed debug broken from previous patch

[xuefeiren]

Created attachment 198839 [details]
fixed debug broken from previous patch

fixed debug broken from previous patch

[Rob Buis]

Comment on attachment 198839 [details]
fixed debug broken from previous patch

Yes, we need this for Debug builds :) Thanks.

[WebKit Commit Bot]

Comment on attachment 198839 [details]
fixed debug broken from previous patch

Clearing flags on attachment: 198839

Committed r148739: <http://trac.webkit.org/changeset/148739>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.