Bug 114844 - [BLACKBERRY]fixed debug broken from previous patch
Summary: [BLACKBERRY]fixed debug broken from previous patch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-18 18:51 PDT by xuefeiren
Modified: 2013-04-19 04:46 PDT (History)
6 users (show)

See Also:

Attachments
fixed debug broken from previous patch (2.26 KB, patch)
2013-04-18 18:58 PDT, xuefeiren 		benjamin: review-
benjamin: commit-queue-
Details | Formatted Diff | Diff
remove warning (unused parameter ) in platform/graphics/blackberry (24.90 KB, patch)
2013-04-18 23:42 PDT, xuefeiren 		no flags Details | Formatted Diff | Diff
fixed debug broken from previous patch (2.26 KB, patch)
2013-04-19 00:09 PDT, xuefeiren 		no flags Details | Formatted Diff | Diff
fixed debug broken from previous patch (2.26 KB, patch)
2013-04-19 03:21 PDT, xuefeiren 		no flags Details | Formatted Diff | Diff
fixed debug broken from previous patch (2.26 KB, patch)
2013-04-19 03:23 PDT, xuefeiren 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description xuefeiren 2013-04-18 18:51:36 PDT 
Source/WebKit/blackberry/WebKitSupport/RenderQueue.cpp
-void RenderQueue::scrollZoomJobsCompleted(const TileIndexList&, TileIndexList* completedJobs, bool shouldBlit)
+void RenderQueue::scrollZoomJobsCompleted(const TileIndexList& outstandingJobs, TileIndexList* completedJobs, bool shouldBlit)
 {
     // Get rid of the completed list!
     ASSERT(outstandingJobs.isEmpty());


in previous patch, remove a useful parameter in debug build.
so now fix it.
Comment 1 xuefeiren 2013-04-18 18:58:03 PDT 
Created attachment 198787 [details]
fixed debug broken from previous patch

fixed debug broken from previous patch
Comment 2 Benjamin Poulain 2013-04-18 22:22:44 PDT 
Comment on attachment 198787 [details]
fixed debug broken from previous patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198787&action=review

> Source/WebKit/blackberry/ChangeLog:10
> +        add missing parameter in 
> +        Source/WebKit/blackberry/WebKitSupport/RenderQueue.cpp
> +        void RenderQueue::scrollZoomJobsCompleted

add -> Add

Remove those lines...

> Source/WebKit/blackberry/ChangeLog:13
> +        * WebKitSupport/RenderQueue.cpp:
> +        (BlackBerry::WebKit::RenderQueue::scrollZoomJobsCompleted):

Add a short description here.

> Source/WebKit/blackberry/WebKitSupport/RenderQueue.cpp:885
>      ASSERT(outstandingJobs.isEmpty());

This should be ASSERT_UNUSED.
Comment 3 xuefeiren 2013-04-18 23:42:36 PDT 
Created attachment 198811 [details]
remove warning (unused parameter ) in platform/graphics/blackberry

remove warning (unused parameter ) in platform/graphics/blackberry
Comment 4 xuefeiren 2013-04-19 00:09:32 PDT 
Created attachment 198816 [details]
fixed debug broken from previous patch

add a parameter which was removed by mistake. now i need to fix it.
Comment 5 xuefeiren 2013-04-19 00:11:22 PDT 
(In reply to comment #2)

> This should be ASSERT_UNUSED.

it is used in ASSERT(), and i removed it in r148677 by mistake. And it broke the debug build,so now I need to add it back.
Comment 6 xuefeiren 2013-04-19 03:21:15 PDT 
Created attachment 198838 [details]
fixed debug broken from previous patch

fixed debug broken from previous patch
Comment 7 xuefeiren 2013-04-19 03:23:06 PDT 
Created attachment 198839 [details]
fixed debug broken from previous patch

fixed debug broken from previous patch
Comment 8 Rob Buis 2013-04-19 04:06:19 PDT 
Comment on attachment 198839 [details]
fixed debug broken from previous patch

Yes, we need this for Debug builds :) Thanks.
Comment 9 WebKit Commit Bot 2013-04-19 04:46:29 PDT 
Comment on attachment 198839 [details]
fixed debug broken from previous patch

Clearing flags on attachment: 198839

Committed r148739: <http://trac.webkit.org/changeset/148739>
Comment 10 WebKit Commit Bot 2013-04-19 04:46:31 PDT 
All reviewed patches have been landed.  Closing bug.