Bug 114817 - Remove obsolete macros from libpng
Summary: Remove obsolete macros from libpng
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-18 09:04 PDT by Alberto Garcia
Modified: 2013-04-18 14:00 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.36 KB, patch)
2013-04-18 09:07 PDT, Alberto Garcia
no flags Details | Formatted Diff | Diff
Patch (1.36 KB, patch)
2013-04-18 09:14 PDT, Alberto Garcia
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2013-04-18 09:04:41 PDT
PNGImageEncoder.cpp uses png_voidp_NULL and png_error_ptr_NULL, which no longer exist in libpng 1.4.

From the changelog:

 b. We removed the typecasted NULL definitions such as

          #define png_voidp_NULL    (png_voidp)NULL

    If you used these in your application, just use NULL instead.

http://www.libpng.org/pub/png/src/libpng-1.2.x-to-1.4.x-summary.txt
Comment 1 Alberto Garcia 2013-04-18 09:07:14 PDT
Created attachment 198741 [details]
Patch
Comment 2 Alberto Garcia 2013-04-18 09:14:22 PDT
Created attachment 198742 [details]
Patch

There was a typo in the changelog message.
Comment 3 WebKit Commit Bot 2013-04-18 14:00:11 PDT
Comment on attachment 198742 [details]
Patch

Clearing flags on attachment: 198742

Committed r148701: <http://trac.webkit.org/changeset/148701>
Comment 4 WebKit Commit Bot 2013-04-18 14:00:13 PDT
All reviewed patches have been landed.  Closing bug.