Bug 114806 - [EFL][WK2] Change inadequate return value in method setDone().
Summary: [EFL][WK2] Change inadequate return value in method setDone().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-18 03:54 PDT by Krzysztof Wolanski
Modified: 2013-04-18 06:07 PDT (History)
3 users (show)

See Also:

Attachments
proposed patch (1.29 KB, patch)
2013-04-18 04:50 PDT, Krzysztof Wolanski 		no flags Details | Formatted Diff | Diff
proposed patch (1.31 KB, patch)
2013-04-18 05:21 PDT, Krzysztof Wolanski 		no flags Details | Formatted Diff | Diff
added [WK2] tag (1.32 KB, patch)
2013-04-18 05:26 PDT, Krzysztof Wolanski 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Wolanski 2013-04-18 03:54:41 PDT 
Fix possible warning in EFL port: no return statement in function returning non-void. Change return value from bool to void in method setDone().
Comment 1 Krzysztof Wolanski 2013-04-18 04:50:08 PDT 
Created attachment 198721 [details]
proposed patch
Comment 2 Chris Dumez 2013-04-18 05:01:26 PDT 
Comment on attachment 198721 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198721&action=review

> Source/WebKit2/ChangeLog:3
> +        [EFL] Change inadequate return value in method setDone().

LGTM but you should add [WK2] tag.
Comment 3 Krzysztof Wolanski 2013-04-18 05:21:01 PDT 
Created attachment 198723 [details]
proposed patch
Comment 4 Krzysztof Wolanski 2013-04-18 05:26:27 PDT 
Created attachment 198724 [details]
added [WK2] tag
Comment 5 Andreas Kling 2013-04-18 05:38:30 PDT 
Comment on attachment 198724 [details]
added [WK2] tag

rs=me
Comment 6 WebKit Commit Bot 2013-04-18 06:07:06 PDT 
Comment on attachment 198724 [details]
added [WK2] tag

Clearing flags on attachment: 198724

Committed r148671: <http://trac.webkit.org/changeset/148671>
Comment 7 WebKit Commit Bot 2013-04-18 06:07:09 PDT 
All reviewed patches have been landed.  Closing bug.