WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
114806
[EFL][WK2] Change inadequate return value in method setDone().
https://bugs.webkit.org/show_bug.cgi?id=114806
Summary
[EFL][WK2] Change inadequate return value in method setDone().
Krzysztof Wolanski
Reported
2013-04-18 03:54:41 PDT
Fix possible warning in EFL port: no return statement in function returning non-void. Change return value from bool to void in method setDone().
Attachments
proposed patch
(1.29 KB, patch)
2013-04-18 04:50 PDT
,
Krzysztof Wolanski
no flags
Details
Formatted Diff
Diff
proposed patch
(1.31 KB, patch)
2013-04-18 05:21 PDT
,
Krzysztof Wolanski
no flags
Details
Formatted Diff
Diff
added [WK2] tag
(1.32 KB, patch)
2013-04-18 05:26 PDT
,
Krzysztof Wolanski
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Krzysztof Wolanski
Comment 1
2013-04-18 04:50:08 PDT
Created
attachment 198721
[details]
proposed patch
Chris Dumez
Comment 2
2013-04-18 05:01:26 PDT
Comment on
attachment 198721
[details]
proposed patch View in context:
https://bugs.webkit.org/attachment.cgi?id=198721&action=review
> Source/WebKit2/ChangeLog:3 > + [EFL] Change inadequate return value in method setDone().
LGTM but you should add [WK2] tag.
Krzysztof Wolanski
Comment 3
2013-04-18 05:21:01 PDT
Created
attachment 198723
[details]
proposed patch
Krzysztof Wolanski
Comment 4
2013-04-18 05:26:27 PDT
Created
attachment 198724
[details]
added [WK2] tag
Andreas Kling
Comment 5
2013-04-18 05:38:30 PDT
Comment on
attachment 198724
[details]
added [WK2] tag rs=me
WebKit Commit Bot
Comment 6
2013-04-18 06:07:06 PDT
Comment on
attachment 198724
[details]
added [WK2] tag Clearing flags on attachment: 198724 Committed
r148671
: <
http://trac.webkit.org/changeset/148671
>
WebKit Commit Bot
Comment 7
2013-04-18 06:07:09 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug