Bug 114782 - JSC: Workaround limited jump range on some CPU architectures
Summary: JSC: Workaround limited jump range on some CPU architectures
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-17 20:04 PDT by Mark Lam
Modified: 2013-04-17 20:16 PDT (History)
7 users (show)

See Also:

Attachments
the fix. (2.70 KB, patch)
2013-04-17 20:07 PDT, Mark Lam 		ddkilzer: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2013-04-17 20:04:00 PDT 
My recent change in https://bugs.webkit.org/show_bug.cgi?id=114577 introduced a "btpnz" to a branch target that is out of reach for some CPU architectures.  In this case, it's simple enough to introduce the use of a jump island, and that saves us from having to change a whole bunch of CPU specific code.  It works out to be a more optimal too.

Patch coming soon.
Comment 1 Mark Lam 2013-04-17 20:07:31 PDT 
Created attachment 198672 [details]
the fix.
Comment 2 David Kilzer (:ddkilzer) 2013-04-17 20:13:14 PDT 
Comment on attachment 198672 [details]
the fix.

r=me with help from Mark to make sure I understood the change.
Comment 3 Mark Lam 2013-04-17 20:16:58 PDT 
Thanks for the review.  Landed in r148655: <http://trac.webkit.org/changeset/148655>.