Bug 114781 – [EFL] inspector-protocol/page/javascriptDialogEvents.html is failing

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Seokju Kwon]

--- /git/WebKit/layout/inspector-protocol/page/javascriptDialogEvents-expected.txt
+++ /git/WebKit/layout/inspector-protocol/page/javascriptDialogEvents-actual.txt
@@ -1,4 +1,4 @@
-CONFIRM NAVIGATION: beforeunload in javascriptDialogEvents
+CONFIRM: beforeunload in javascriptDialogEvents
 ALERT: alert
 CONFIRM: confirm
 PROMPT: prompt, default text:

[Seokju Kwon]

Created attachment 198671 [details]
Patch

[Seokju Kwon]

gyuyoung : What do you think about it?

[Chris Dumez]

Comment on attachment 198671 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198671&action=review

> Source/WebKit/efl/ChangeLog:9
> +

Please check the following entry in efl-wk1 TestExpectations:
# EFL's DRT needs CONFIRM NAVIGATION messages
webkit.org/b/87246 fast/loader/form-submission-after-beforeunload-cancel.html [ Failure ]

If the test now passes please unskip it in this patch.

> Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:97
> +    return EINA_TRUE;

You need to return !gTestRunner->shouldStayOnPageAfterHandlingBeforeUnload() instead of unconditionally EINA_TRUE I believe. Please check other ports.

[Chris Dumez]

*** Bug 87246 has been marked as a duplicate of this bug. ***

[Seokju Kwon]

(In reply to comment #3)
> (From update of attachment 198671 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=198671&action=review
> 
> > Source/WebKit/efl/ChangeLog:9
> > +
> 
> Please check the following entry in efl-wk1 TestExpectations:
> # EFL's DRT needs CONFIRM NAVIGATION messages
> webkit.org/b/87246 fast/loader/form-submission-after-beforeunload-cancel.html [ Failure ]
> 
> If the test now passes please unskip it in this patch.
> 
> > Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:97
> > +    return EINA_TRUE;
> 
> You need to return !gTestRunner->shouldStayOnPageAfterHandlingBeforeUnload() instead of unconditionally EINA_TRUE I believe. Please check other ports.

Chris : Thanks for your review and comments. I will check them out.

[Seokju Kwon]

Created attachment 201995 [details]
Patch

[Chris Dumez]

Comment on attachment 201995 [details]
Patch

Looks fine, r=me but Gyuyoung may want to take a look before landing as it touches Wk1 API.

[Gyuyoung Kim]

Comment on attachment 201995 [details]
Patch

Looks fine as well.

[WebKit Commit Bot]

Comment on attachment 201995 [details]
Patch

Clearing flags on attachment: 201995

Committed r150241: <http://trac.webkit.org/changeset/150241>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.