114777 – Renamed JSGlobalData to VM

RESOLVED FIXED Bug 114777

Renamed JSGlobalData to VM

https://bugs.webkit.org/show_bug.cgi?id=114777

Summary Renamed JSGlobalData to VM

Geoffrey Garen

Reported 2013-04-17 17:48:38 PDT

Renamed JSGlobalData to VM

Attachments
Patch (1.90 MB, patch) 2013-04-17 17:55 PDT, Geoffrey Garen	no flags	Details Formatted Diff Diff
Patch (1.90 MB, patch) 2013-04-17 20:38 PDT, Geoffrey Garen	no flags	Details Formatted Diff Diff
Patch (1.90 MB, patch) 2013-04-17 20:59 PDT, Geoffrey Garen	no flags	Details Formatted Diff Diff
Patch (1.90 MB, patch) 2013-04-18 10:52 PDT, Geoffrey Garen	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Geoffrey Garen

Comment 1 2013-04-17 17:55:37 PDT

Created attachment 198635 [details] Patch

Mark Lam

Comment 2 2013-04-17 18:25:58 PDT

Comment on attachment 198635 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=198635&action=review > Source/JavaScriptCore/JavaScriptCore.order:26 > +__ZN3JSC12VM10storeVPtrsEv Shouldn't this be __ZN3JSC2VM10storeVPtrsEv (the 12 preceding JSGlobalData is now 2 preceding VM)? > Source/JavaScriptCore/JavaScriptCore.order:123 > -__ZN3JSC12JSGlobalData14sharedInstanceEv > -__ZN3JSC12JSGlobalDataC2ENS0_14GlobalDataTypeENS_8HeapTypeE > +__ZN3JSC12VM14sharedInstanceEv > +__ZN3JSC12VMC2ENS0_14GlobalDataTypeENS_8HeapTypeE Ditto. 12 ==> 2. > Source/JavaScriptCore/JavaScriptCore.order:127 > -__ZN3JSC17CommonIdentifiersC1EPNS_12JSGlobalDataE > -__ZN3JSC17CommonIdentifiersC2EPNS_12JSGlobalDataE > -__ZN3JSC10Identifier3addEPNS_12JSGlobalDataEPKc > +__ZN3JSC17CommonIdentifiersC1EPNS_12VME > +__ZN3JSC17CommonIdentifiersC2EPNS_12VME > +__ZN3JSC10Identifier3addEPNS_12VMEPKc 12 => 2. > Source/JavaScriptCore/JavaScriptCore.order:132 > -__ZN3JSC10IdentifierC1EPNS_12JSGlobalDataEPKc > +__ZN3JSC10IdentifierC1EPNS_12VMEPKc 12 => 2. > Source/JavaScriptCore/JavaScriptCore.order:139 > -__ZN3JSC5LexerC1EPNS_12JSGlobalDataE > +__ZN3JSC5LexerC1EPNS_12VME 12 => 2. > Source/JavaScriptCore/JavaScriptCore.order:145 > -__ZN3JSC4HeapC1EPNS_12JSGlobalDataE > -__ZN3JSC4HeapC2EPNS_12JSGlobalDataE > -__ZN3JSC11MarkedSpaceC1EPNS_12JSGlobalDataE > +__ZN3JSC4HeapC1EPNS_12VME > +__ZN3JSC4HeapC2EPNS_12VME > +__ZN3JSC11MarkedSpaceC1EPNS_12VME 12 => 2. > Source/JavaScriptCore/JavaScriptCore.order:151 > -__ZN3JSC10HandleHeapC1EPNS_12JSGlobalDataE > +__ZN3JSC10HandleHeapC1EPNS_12VME 12 => 2. > Source/JavaScriptCore/JavaScriptCore.order:159 > -__ZN3JSC11RegExpCacheC1EPNS_12JSGlobalDataE > -__ZN3JSC11InterpreterC1ERNS_12JSGlobalDataE > +__ZN3JSC11RegExpCacheC1EPNS_12VME > +__ZN3JSC11InterpreterC1ERNS_12VME 12 => 2. > Source/JavaScriptCore/JavaScriptCore.order:164 > -__ZN3JSC11MarkedBlock6createEPNS_12JSGlobalDataEm > +__ZN3JSC11MarkedBlock6createEPNS_12VMEm 12 => 2. > Source/JavaScriptCore/JavaScriptCore.order:171 > -__ZN3JSC9StructureC1ERNS_12JSGlobalDataE > -__ZN3JSC6StrongINS_9StructureEE3setERNS_12JSGlobalDataEPS1_ > -__ZN3JSC9Structure6createERNS_12JSGlobalDataENS_7JSValueERKNS_8TypeInfoEjPKNS_9ClassInfoE > -__ZN3JSC9StructureC1ERNS_12JSGlobalDataENS_7JSValueERKNS_8TypeInfoEjPKNS_9ClassInfoE > +__ZN3JSC9StructureC1ERNS_12VME > +__ZN3JSC6StrongINS_9StructureEE3setERNS_12VMEPS1_ > +__ZN3JSC9Structure6createERNS_12VMENS_7JSValueERKNS_8TypeInfoEjPKNS_9ClassInfoE > +__ZN3JSC9StructureC1ERNS_12VMENS_7JSValueERKNS_8TypeInfoEjPKNS_9ClassInfoE 12 => 2. > Source/JavaScriptCore/JavaScriptCore.order:180 > -__ZN3JSC9JITThunksC1EPNS_12JSGlobalDataE > -__ZN3JSC9JITThunksC2EPNS_12JSGlobalDataE > -__ZN3JSC3JITC1EPNS_12JSGlobalDataEPNS_9CodeBlockE > -__ZN3JSC3JITC2EPNS_12JSGlobalDataEPNS_9CodeBlockE > -__ZN3JSC3JIT35privateCompileCTIMachineTrampolinesEPN3WTF6RefPtrINS_14ExecutablePoolEEEPNS_12JSGlobalDataEPNS_19TrampolineStructureE > +__ZN3JSC9JITThunksC1EPNS_12VME > +__ZN3JSC9JITThunksC2EPNS_12VME > +__ZN3JSC3JITC1EPNS_12VMEPNS_9CodeBlockE > +__ZN3JSC3JITC2EPNS_12VMEPNS_9CodeBlockE > +__ZN3JSC3JIT35privateCompileCTIMachineTrampolinesEPN3WTF6RefPtrINS_14ExecutablePoolEEEPNS_12VMEPNS_19TrampolineStructureE 12 => 2. > Source/JavaScriptCore/JavaScriptCore.order:195 > -__ZN3JSC3JIT27privateCompileCTINativeCallEPNS_12JSGlobalDataEb > +__ZN3JSC3JIT27privateCompileCTINativeCallEPNS_12VMEb 12 => 2. > Source/JavaScriptCore/JavaScriptCore.order:203 > -__ZN3JSC14JSGlobalObjectnwEmPNS_12JSGlobalDataE > +__ZN3JSC14JSGlobalObjectnwEmPNS_12VME 12 => 2. > Source/JavaScriptCore/JavaScriptCore.order:211 > -__ZN3JSC16InternalFunctionC2EPNS_12JSGlobalDataEPNS_14JSGlobalObjectEPNS_9StructureERKNS_10IdentifierE > +__ZN3JSC16InternalFunctionC2EPNS_12VMEPNS_14JSGlobalObjectEPNS_9StructureERKNS_10IdentifierE 12 => 2. And so on below ...

Geoffrey Garen

Comment 3 2013-04-17 19:00:33 PDT

> > Source/JavaScriptCore/JavaScriptCore.order:26 > > +__ZN3JSC12VM10storeVPtrsEv > > Shouldn't this be __ZN3JSC2VM10storeVPtrsEv (the 12 preceding JSGlobalData is now 2 preceding VM)? You're probably right, but it's OK for the .order file to be wrong for now. It's just an optimization, not a correctness issue, and we re-auto-generate it for each release.

Geoffrey Garen

Comment 4 2013-04-17 20:38:02 PDT

Created attachment 198674 [details] Patch

EFL EWS Bot

Comment 5 2013-04-17 20:46:37 PDT

Comment on attachment 198674 [details] Patch Attachment 198674 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/172113

Geoffrey Garen

Comment 6 2013-04-17 20:59:12 PDT

Created attachment 198675 [details] Patch

Geoffrey Garen

Comment 7 2013-04-18 10:52:24 PDT

Created attachment 198746 [details] Patch

Geoffrey Garen

Comment 8 2013-04-18 12:30:58 PDT

Committed r148696: <http://trac.webkit.org/changeset/148696>

Benjamin Poulain

Comment 9 2013-04-18 13:42:57 PDT

Comment on attachment 198746 [details] Patch Looks like this is landed already.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version 528+ (Nightly build)

Hardware Unspecified

OS Unspecified

Product WebKit

Component New Bugs

Assignee

Geoffrey Garen

Reported

2013-04-17 17:48 PDT

Modified

2013-04-18 13:42 PDT History

CC List

2 users Show

URL

Keywords

Depends on

Blocks