Bug 114769 - Content inside frames and scrollbars in overflow areas hit-tests incorrectly when the WKView has a header
Summary: Content inside frames and scrollbars in overflow areas hit-tests incorrectly ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Beth Dakin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-04-17 15:13 PDT by Beth Dakin
Modified: 2013-04-17 16:22 PDT (History)
3 users (show)

See Also:


Attachments
Patch (7.65 KB, patch)
2013-04-17 15:34 PDT, Beth Dakin
no flags Details | Formatted Diff | Diff
Patch (6.95 KB, patch)
2013-04-17 16:15 PDT, Beth Dakin
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2013-04-17 15:13:09 PDT
Content inside frames and scrollbars in overflow areas hit-tests incorrectly when the WKView has a header. 

<rdar://problem/13581721>
Comment 1 Beth Dakin 2013-04-17 15:34:12 PDT
Created attachment 198619 [details]
Patch
Comment 2 Simon Fraser (smfr) 2013-04-17 15:51:31 PDT
Comment on attachment 198619 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198619&action=review

> LayoutTests/platform/mac/platform/mac-wk2/tiled-drawing/header-and-footer-hit-testing-in-frame-expected.txt:16
> +layer at (0,0) size 785x600
> +  RenderView at (0,0) size 785x600
> +layer at (0,0) size 785x600
> +  RenderBlock {HTML} at (0,0) size 785x600
> +    RenderBody {BODY} at (8,8) size 769x584
> +      RenderPartObject {IFRAME} at (0,0) size 600x300
> +        layer at (0,0) size 600x300
> +          RenderView at (0,0) size 600x300
> +        layer at (0,0) size 600x300
> +          RenderBlock {HTML} at (0,0) size 600x300
> +            RenderBody {BODY} at (8,8) size 584x284
> +              RenderBlock {DIV} at (0,0) size 25x25 [bgcolor=#800080]
> +              RenderBlock {DIV} at (0,25) size 584x18
> +                RenderText {#text} at (0,0) size 33x18
> +                  text run at (0,0) width 33: "Pass!"
> +      RenderText {#text} at (0,0) size 0x0

This should be a text test.
Comment 3 Beth Dakin 2013-04-17 16:13:07 PDT
(In reply to comment #2)
> (From update of attachment 198619 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=198619&action=review
> 
> > LayoutTests/platform/mac/platform/mac-wk2/tiled-drawing/header-and-footer-hit-testing-in-frame-expected.txt:16
> > +layer at (0,0) size 785x600
> > +  RenderView at (0,0) size 785x600
> > +layer at (0,0) size 785x600
> > +  RenderBlock {HTML} at (0,0) size 785x600
> > +    RenderBody {BODY} at (8,8) size 769x584
> > +      RenderPartObject {IFRAME} at (0,0) size 600x300
> > +        layer at (0,0) size 600x300
> > +          RenderView at (0,0) size 600x300
> > +        layer at (0,0) size 600x300
> > +          RenderBlock {HTML} at (0,0) size 600x300
> > +            RenderBody {BODY} at (8,8) size 584x284
> > +              RenderBlock {DIV} at (0,0) size 25x25 [bgcolor=#800080]
> > +              RenderBlock {DIV} at (0,25) size 584x18
> > +                RenderText {#text} at (0,0) size 33x18
> > +                  text run at (0,0) width 33: "Pass!"
> > +      RenderText {#text} at (0,0) size 0x0
> 
> This should be a text test.

Yes, it should! This was much easier to do than I initially though. New patch in a moment.
Comment 4 Beth Dakin 2013-04-17 16:15:08 PDT
Created attachment 198627 [details]
Patch
Comment 5 Beth Dakin 2013-04-17 16:22:54 PDT
Thank you! 

http://trac.webkit.org/changeset/148643