Bug 114768 – Automate generation of toJS function for classes that need to report extra memory usage

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Oliver Hunt]

Automate generation of toJS function for classes that need to report extra memory usage

[Oliver Hunt]

Created attachment 198614 [details]
Patch

[Geoffrey Garen]

Comment on attachment 198614 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198614&action=review

r=me

> Source/WebCore/bindings/js/JSDOMBinding.h:528
> +        typedef char YesType;

Let's call this HasMemoryCostMemberFunction.

> Source/WebCore/bindings/js/JSDOMBinding.h:544
> +        static NoType memoryCostCheck(U*, TypeChecker<void (BaseMixin::*)(), &U::memoryCost>* = 0);
> +        static YesType memoryCostCheck(...);

Let's call these dummy.

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2718
> +template <typename T, bool hasReportCostFunction = HasMemoryCost<T>::value > struct ReportCost;

Let's call this "template<typename T, bool hasMemoryCostMemberFunction = HasMemoryCostMemberFunction<T>::value> struct ReportMemoryCost".

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2720
> +    static void reportExtraCost(ExecState* exec, T* impl)

Let's call this reportMemoryCost.

[Build Bot]

Comment on attachment 198614 [details]
Patch

Attachment 198614 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/102507

[Oliver Hunt]

Created attachment 198621 [details]
Patch

[Oliver Hunt]

Just making sure that i haven't horned windows

[Oliver Hunt]

Comment on attachment 198621 [details]
Patch

Committed r148648

[Roger Fong]

(In reply to comment #5)
> Just making sure that i haven't horned windows

Unfortunately it would seem that another build failure was masking this one, or something along those lines:

http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/47641/steps/compile-webkit/logs/stdio

Any idea how to fix it?

I've tried a clean build, also curious that one bot (The opensource debug builder) seems to be okay with the change...

[Oliver Hunt]

(In reply to comment #7)
> (In reply to comment #5)
> > Just making sure that i haven't horned windows
> 
> Unfortunately it would seem that another build failure was masking this one, or something along those lines:
> 
> http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/47641/steps/compile-webkit/logs/stdio
> 
> Any idea how to fix it?
> 
> I've tried a clean build, also curious that one bot (The opensource debug builder) seems to be okay with the change...

The bot seems to be trying to share the definition of ReportMemoryCost between different JS bindings files, has someone decided to allinonefile them?