Bug 114756 - [Dashboard] Clean up the timeline updating code, removing Chromium-specific cases
Summary: [Dashboard] Clean up the timeline updating code, removing Chromium-specific c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on: 114755
Blocks: 114605
  Show dependency treegraph
 
Reported: 2013-04-17 12:55 PDT by Zan Dobersek
Modified: 2013-04-17 13:38 PDT (History)
0 users

See Also:


Attachments
Patch (3.00 KB, patch)
2013-04-17 12:58 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-04-17 12:55:28 PDT
[Dashboard] Clean up the timeline updating code, removing Chromium-specific cases
Comment 1 Zan Dobersek 2013-04-17 12:58:14 PDT
Created attachment 198598 [details]
Patch
Comment 2 Ryosuke Niwa 2013-04-17 13:04:02 PDT
Comment on attachment 198598 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198598&action=review

> Tools/TestResultServer/static-dashboards/timeline_explorer.js:-114
> -function shouldShowWebKitRevisionsOnly()

This function is also called in updateTimelineForBuilder so this patch depends on https://bugs.webkit.org/show_bug.cgi?id=114755.
Comment 3 Zan Dobersek 2013-04-17 13:38:01 PDT
Comment on attachment 198598 [details]
Patch

Clearing flags on attachment: 198598

Committed r148631: <http://trac.webkit.org/changeset/148631>
Comment 4 Zan Dobersek 2013-04-17 13:38:05 PDT
All reviewed patches have been landed.  Closing bug.