Bug 114741 - [BlackBerry] ASSERT in FrameLoaderClient::convertMainResourceLoadToDownload
Summary: [BlackBerry] ASSERT in FrameLoaderClient::convertMainResourceLoadToDownload
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-17 07:18 PDT by Xan Lopez
Modified: 2013-04-22 07:23 PDT (History)
7 users (show)

See Also:


Attachments
no-stream.diff (3.80 KB, patch)
2013-04-17 07:21 PDT, Xan Lopez
no flags Details | Formatted Diff | Diff
no-stream.diff (3.71 KB, patch)
2013-04-17 07:29 PDT, Xan Lopez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xan Lopez 2013-04-17 07:18:16 PDT
The test fast/dom/HTMLAnchorElement/anchor-nodownload-set.html tries to trigger a download for a Blob object. Our download code assumes all ResourceHandles have an associated FilterStream object (set on the ::start method for ResourceHandle), but Blob objects have their own ResourceHandle class which does not this (since they are not really retrieved from the network). This makes us crash when we ASSERT the stream object, since it will be null. As a workaround, call the right methods in our networking layer from FrameLoaderClient itself.

Note that this does not yet fix this test, since there's at least another bug involved.
Comment 1 Xan Lopez 2013-04-17 07:21:25 PDT
Created attachment 198507 [details]
no-stream.diff
Comment 2 Xan Lopez 2013-04-17 07:29:58 PDT
Created attachment 198508 [details]
no-stream.diff

Applies properly against trunk.
Comment 3 Joe Mason 2013-04-17 07:53:59 PDT
Comment on attachment 198508 [details]
no-stream.diff

View in context: https://bugs.webkit.org/attachment.cgi?id=198508&action=review

> Source/WebKit/blackberry/ChangeLog:7
> +

You can add "Internally reviewed by Joe Mason" to this changelog message. (Plus you should add the PR number if we have an internal PR for it.)
Comment 4 Xan Lopez 2013-04-22 04:40:13 PDT
Ping about this? As Joe says, it's been already reviewed by him internally.
Comment 5 WebKit Commit Bot 2013-04-22 07:23:44 PDT
Comment on attachment 198508 [details]
no-stream.diff

Clearing flags on attachment: 198508

Committed r148880: <http://trac.webkit.org/changeset/148880>
Comment 6 WebKit Commit Bot 2013-04-22 07:23:47 PDT
All reviewed patches have been landed.  Closing bug.