Bug 114740 - Add checking whether the compiler allows to use #pragma directive.
Summary: Add checking whether the compiler allows to use #pragma directive.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-17 06:46 PDT by Krzysztof Wolanski
Modified: 2013-04-18 05:54 PDT (History)
4 users (show)

See Also:


Attachments
proposed patch (1.19 KB, patch)
2013-04-17 06:51 PDT, Krzysztof Wolanski
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Wolanski 2013-04-17 06:46:20 PDT
Some compilers may complain that #pragma warning is an undefined macro.
Comment 1 Krzysztof Wolanski 2013-04-17 06:51:02 PDT
Created attachment 198504 [details]
proposed patch
Comment 2 Andreas Kling 2013-04-18 05:41:38 PDT
Comment on attachment 198504 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198504&action=review

> Source/ThirdParty/ANGLE/src/compiler/depgraph/DependencyGraph.cpp:7
> +#if defined(_MSC_VER)

This should be #if COMPILER(MSVC)
Otherwise, it looks fine.
Comment 3 Andreas Kling 2013-04-18 05:42:36 PDT
(In reply to comment #2)
> (From update of attachment 198504 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=198504&action=review
> 
> > Source/ThirdParty/ANGLE/src/compiler/depgraph/DependencyGraph.cpp:7
> > +#if defined(_MSC_VER)
> 
> This should be #if COMPILER(MSVC)
> Otherwise, it looks fine.

Actually, since this is in ANGLE.. I guess we don't have config.h / wtf/Platform.h included.
Comment 4 Andreas Kling 2013-04-18 05:44:37 PDT
Comment on attachment 198504 [details]
proposed patch

Okay, I got that wrong. Checking MSC_VER directly is fine in ANGLE.
r=me!
Comment 5 WebKit Commit Bot 2013-04-18 05:54:43 PDT
Comment on attachment 198504 [details]
proposed patch

Clearing flags on attachment: 198504

Committed r148669: <http://trac.webkit.org/changeset/148669>
Comment 6 WebKit Commit Bot 2013-04-18 05:54:46 PDT
All reviewed patches have been landed.  Closing bug.