RESOLVED FIXED 114740
Add checking whether the compiler allows to use #pragma directive. 
https://bugs.webkit.org/show_bug.cgi?id=114740
Summary Add checking whether the compiler allows to use #pragma directive.
Krzysztof Wolanski
Reported 2013-04-17 06:46:20 PDT
Some compilers may complain that #pragma warning is an undefined macro.
Attachments
proposed patch (1.19 KB, patch)
2013-04-17 06:51 PDT, Krzysztof Wolanski 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Krzysztof Wolanski
Comment 1 2013-04-17 06:51:02 PDT
Created attachment 198504 [details] proposed patch
Andreas Kling
Comment 2 2013-04-18 05:41:38 PDT
Comment on attachment 198504 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=198504&action=review > Source/ThirdParty/ANGLE/src/compiler/depgraph/DependencyGraph.cpp:7 > +#if defined(_MSC_VER) This should be #if COMPILER(MSVC) Otherwise, it looks fine.
Andreas Kling
Comment 3 2013-04-18 05:42:36 PDT
(In reply to comment #2) > (From update of attachment 198504 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=198504&action=review > > > Source/ThirdParty/ANGLE/src/compiler/depgraph/DependencyGraph.cpp:7 > > +#if defined(_MSC_VER) > > This should be #if COMPILER(MSVC) > Otherwise, it looks fine. Actually, since this is in ANGLE.. I guess we don't have config.h / wtf/Platform.h included.
Andreas Kling
Comment 4 2013-04-18 05:44:37 PDT
Comment on attachment 198504 [details] proposed patch Okay, I got that wrong. Checking MSC_VER directly is fine in ANGLE. r=me!
WebKit Commit Bot
Comment 5 2013-04-18 05:54:43 PDT
Comment on attachment 198504 [details] proposed patch Clearing flags on attachment: 198504 Committed r148669: <http://trac.webkit.org/changeset/148669>
WebKit Commit Bot
Comment 6 2013-04-18 05:54:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.