Bug 114717 - Web Inspector: make generate-inspector-protocol-version work with python3
Summary: Web Inspector: make generate-inspector-protocol-version work with python3
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-16 18:14 PDT by Sergio Correia (qrwteyrutiyoup)
Modified: 2013-04-17 13:13 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.88 KB, patch)
2013-04-16 18:15 PDT, Sergio Correia (qrwteyrutiyoup) 		no flags Details | Formatted Diff | Diff
Patch (1.88 KB, patch)
2013-04-16 19:29 PDT, Sergio Correia (qrwteyrutiyoup) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Correia (qrwteyrutiyoup) 2013-04-16 18:14:02 PDT 
Web Inspector: make generate-inspector-protocol-version work with python3
Comment 1 Sergio Correia (qrwteyrutiyoup) 2013-04-16 18:15:28 PDT 
Created attachment 198456 [details]
Patch

Proposed patch
Comment 2 Joseph Pecoraro 2013-04-16 18:54:54 PDT 
Comment on attachment 198456 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198456&action=review

Looks good. Just get that typo in the ChangeLog fixed if possible!

> Source/WebCore/ChangeLog:10
> +        to the sys.stderr.write() ones already used througout the file.

Typo: "througout" => "throughout"
Comment 3 Sergio Correia (qrwteyrutiyoup) 2013-04-16 19:29:59 PDT 
Created attachment 198459 [details]
Patch

Typo fixed in changelog and commit message.
Comment 4 Timothy Hatcher 2013-04-17 12:34:25 PDT 
Comment on attachment 198459 [details]
Patch

I assume this works with older python versions still?
Comment 5 Sergio Correia (qrwteyrutiyoup) 2013-04-17 12:42:17 PDT 
(In reply to comment #4)
> (From update of attachment 198459 [details])
> I assume this works with older python versions still?

Yup, it keeps working with python2 as expected, since that is what is officially supported.

I had some odd setup in here when it crashed on me, and since I saw revision
https://bugs.webkit.org/show_bug.cgi?id=106194, I thought to keep it working with python3, assuming someone uses it somehow.

All in all, this patch merely makes the file more consistent, since we already have sys.stderr.write, and now sys.stdout.write too.
Comment 6 Timothy Hatcher 2013-04-17 12:43:25 PDT 
Comment on attachment 198459 [details]
Patch

Thanks!
Comment 7 WebKit Commit Bot 2013-04-17 13:13:15 PDT 
Comment on attachment 198459 [details]
Patch

Clearing flags on attachment: 198459

Committed r148630: <http://trac.webkit.org/changeset/148630>
Comment 8 WebKit Commit Bot 2013-04-17 13:13:17 PDT 
All reviewed patches have been landed.  Closing bug.