Bug 114716 - Harden FastMalloc against partial pointer overflows
Summary: Harden FastMalloc against partial pointer overflows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-16 17:39 PDT by Oliver Hunt
Modified: 2013-04-16 18:11 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.86 KB, patch)
2013-04-16 17:42 PDT, Oliver Hunt 		barraclough: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2013-04-16 17:39:14 PDT 
Harden FastMalloc against partial pointer overflows
Comment 1 Oliver Hunt 2013-04-16 17:42:53 PDT 
Created attachment 198455 [details]
Patch
Comment 2 WebKit Commit Bot 2013-04-16 17:43:56 PDT 
Attachment 198455 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/FastMalloc.cpp']" exit_code: 1
Source/WTF/wtf/FastMalloc.cpp:3993:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:3994:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:3995:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:3997:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:4010:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 5 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gavin Barraclough 2013-04-16 17:46:36 PDT 
Comment on attachment 198455 [details]
Patch

preemptive RS=me for a patch the renames the random characters to proper variable names.
Comment 4 Oliver Hunt 2013-04-16 18:11:42 PDT 
Committed r148587: <http://trac.webkit.org/changeset/148587>