There are a few issues with the JSCore.gir.in. It's essentially a stub file that enables introspection of APIs, but is mostly incomplete. JavaScriptCore isn't a GObject API, which suggests that using it will lead to memory errors. Instead it should likely be a "foreign" library defined like https://git.gnome.org/browse/gobject-introspection/tree/gir/cairo-1.0.gir.in. It references the libwebkitgtk library when it should really be referencing libjavascriptcoregtk.
Created attachment 198897 [details] Patch
Comment on attachment 198897 [details] Patch Clearing flags on attachment: 198897 Committed r148755: <http://trac.webkit.org/changeset/148755>
All reviewed patches have been landed. Closing bug.
Comment on attachment 198897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=198897&action=review Nice cleanup! > Source/JavaScriptCore/GNUmakefile.am:211 > +CLEANFILES += JavaScriptCore-@WEBKITGTK_API_VERSION@.gir JavaScriptCore-@WEBKITGTK_API_VERSION@.typelib Now that gir_DATA and typelibs_DATA are common and global, I wonder if we could simply add CLEANFILES += $(gir_DATA) $(typelibs_DATA) to the main makefile and we don't need to do it for every GIR. > Source/WebKit/gtk/GNUmakefile.am:-356 > -EXTRA_DIST += $(top_builddir)/Source/WebKit/gtk/JSCore-@WEBKITGTK_API_VERSION@.gir > - This is no longer needed? Have you checked this patch doesn't break distcheck?
(In reply to comment #4) > (From update of attachment 198897 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=198897&action=review > > Nice cleanup! > > > Source/JavaScriptCore/GNUmakefile.am:211 > > +CLEANFILES += JavaScriptCore-@WEBKITGTK_API_VERSION@.gir JavaScriptCore-@WEBKITGTK_API_VERSION@.typelib > > Now that gir_DATA and typelibs_DATA are common and global, I wonder if we could simply add CLEANFILES += $(gir_DATA) $(typelibs_DATA) to the main makefile and we don't need to do it for every GIR. I wonder if we'll need to split the introspection bits of the main makefile up for that -- one before the includes and one after. > > Source/WebKit/gtk/GNUmakefile.am:-356 > > -EXTRA_DIST += $(top_builddir)/Source/WebKit/gtk/JSCore-@WEBKITGTK_API_VERSION@.gir > > - > > This is no longer needed? Have you checked this patch doesn't break distcheck? 'make dist' is broken at the moment, but I double-checked that Source/JavaScriptCore/JavaScriptCore.gir.in was in DIST_COMMON in the makefile. If AC_CONFIG_FILE doesn't automatically dist the source files, we'd need to put the other files used in AC_CONFIG_FILES in EXTRA_DIST as well.