Created attachment 198443 [details]
Created attachment 198473 [details]
Created attachment 198586 [details]
Committed r148620: <http://trac.webkit.org/changeset/148620>
Did you look at https://trac.webkit.org/changeset/59171 before you made this change?
AFAIK this ugly construct is not just for fun.
Bah! Stupid history. It looks like Bug 38930 needs to be addressed somehow.
(In reply to comment #8)
> Bah! Stupid history. It looks like Bug 38930 needs to be addressed somehow.
+1 :) Rollout?
Pleas think about using EXPORT macros for the Windows port too. There might be a bunch of problems when you link the symbols two time and it makes the stuff not really easier to understand....
IMHO the only right way is to create an additional "WTFString" static library.
BTW: Maybe you can implement the last missing part in the "export symbols on Windows" stuff: I only have a CMake based VS solution file. If you look at https://bugs.webkit.org/attachment.cgi?id=196804 and search for "generate-win32-export-forwards" you find the only missing part to get rid of the export file on Windows too.
This change has been superseded by https://bugs.webkit.org/show_bug.cgi?id=117050.