Bug 114697 - PlugIns that resize in user gestures should be immune to snapshotting
Summary: PlugIns that resize in user gestures should be immune to snapshotting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-04-16 13:15 PDT by Dean Jackson
Modified: 2013-04-16 15:00 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.41 KB, patch)
2013-04-16 13:59 PDT, Dean Jackson 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2013-04-16 13:15:12 PDT 
https://bugs.webkit.org/show_bug.cgi?id=102157 introduced detecting if a plugin resizes above the snapshotting threshold. But plugins that do this in response to user gestures should not snapshot.
Comment 1 Radar WebKit Bug Importer 2013-04-16 13:15:42 PDT 
<rdar://problem/13666258>
Comment 2 Dean Jackson 2013-04-16 13:59:16 PDT 
Created attachment 198426 [details]
Patch
Comment 3 Tim Horton 2013-04-16 14:00:44 PDT 
Comment on attachment 198426 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198426&action=review

> Source/WebCore/html/HTMLPlugInImageElement.cpp:556
> +    if (!m_needsCheckForSizeChange || m_snapshotDecision != MaySnapshotWhenResized || wasRecentUserGesture(document()))

the document was not a recent user gesture. perhaps had* or saw*?
Comment 4 Dean Jackson 2013-04-16 14:57:18 PDT 
Changed to documentHadRecentUserGesture
Comment 5 Dean Jackson 2013-04-16 15:00:56 PDT 
https://trac.webkit.org/r148547