Bug 114681 - [refactor] Moved ScriptedAnimationController clearance code to common function
Summary: [refactor] Moved ScriptedAnimationController clearance code to common function
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Enhancement
Assignee: Bruno Abinader (history only)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-16 05:59 PDT by Bruno Abinader (history only)
Modified: 2013-04-17 11:15 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.60 KB, patch)
2013-04-16 06:02 PDT, Bruno Abinader (history only)
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (3.04 KB, patch)
2013-04-16 06:39 PDT, Bruno Abinader (history only)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bruno Abinader (history only) 2013-04-16 05:59:29 PDT
Avoided duplicated code by moving ScriptedAnimationController clearance code to an inline function to be used by both Document::dispose() and Document::detach().
Comment 1 Bruno Abinader (history only) 2013-04-16 06:02:35 PDT
Created attachment 198320 [details]
Patch
Comment 2 EFL EWS Bot 2013-04-16 06:10:12 PDT
Comment on attachment 198320 [details]
Patch

Attachment 198320 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/171013
Comment 3 Bruno Abinader (history only) 2013-04-16 06:39:16 PDT
Created attachment 198327 [details]
Patch

Moved implementation code out of header as ScriptedAnimationController is forward declared in Document.cpp source.
Comment 4 WebKit Commit Bot 2013-04-17 11:15:34 PDT
Comment on attachment 198327 [details]
Patch

Clearing flags on attachment: 198327

Committed r148618: <http://trac.webkit.org/changeset/148618>
Comment 5 WebKit Commit Bot 2013-04-17 11:15:37 PDT
All reviewed patches have been landed.  Closing bug.