lockBufferDrawable() can return a null pointer, so it should be checked first.
Created attachment 198280 [details] Patch
Comment on attachment 198280 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=198280&action=review > Source/WebCore/platform/graphics/blackberry/LayerTexture.cpp:-70 > - gc->addFillRect(BlackBerry::Platform::FloatRect(0, 0, 1, 1)); Why was this never a problem before? Did the semantics of lockBufferDrawable change? > Source/WebCore/platform/graphics/blackberry/LayerTexture.cpp:69 > + if (gc) { It is WebKit style to put the temp var declaration in the if.
Created attachment 198333 [details] Patch (In reply to comment #2) > > Source/WebCore/platform/graphics/blackberry/LayerTexture.cpp:-70 > > - gc->addFillRect(BlackBerry::Platform::FloatRect(0, 0, 1, 1)); > Why was this never a problem before? Did the semantics of > lockBufferDrawable change? They didn't, it can actually return a null pointer. I don't think it's the case here anyway but see also bug 114005. > > Source/WebCore/platform/graphics/blackberry/LayerTexture.cpp:69 > > + if (gc) { > It is WebKit style to put the temp var declaration in the if. Ok, fixed.
Comment on attachment 198333 [details] Patch LGTM.
Comment on attachment 198333 [details] Patch Clearing flags on attachment: 198333 Committed r148516: <http://trac.webkit.org/changeset/148516>
All reviewed patches have been landed. Closing bug.