WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
114673
The list of contributors in committers.py should be a separate JSON
https://bugs.webkit.org/show_bug.cgi?id=114673
Summary
The list of contributors in committers.py should be a separate JSON
Ryosuke Niwa
Reported
2013-04-16 02:14:46 PDT
We should extract the list of contributors, committers, and reviewers into a JSON file. There’s no point in forcing everyone to read through Python code.
Attachments
Cleanup
(92.32 KB, patch)
2013-04-16 03:29 PDT
,
Ryosuke Niwa
no flags
Details
Formatted Diff
Diff
Always use emails and nicks
(94.09 KB, patch)
2013-04-16 10:34 PDT
,
Ryosuke Niwa
andersca
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2013-04-16 02:15:38 PDT
This will also allow Bugzilla and other websites and tools to parse the list of contributors in JavaScript more easily.
Ryosuke Niwa
Comment 2
2013-04-16 03:29:30 PDT
Created
attachment 198315
[details]
Cleanup
Csaba Osztrogonác
Comment 3
2013-04-16 04:12:46 PDT
Comment on
attachment 198315
[details]
Cleanup LGTM, but using email/email and nick/nicks in the JSON is a little bit strange for me. I prefer a simpler syntax, only email and nick. It is so easy to check if an instance is a string or a list: isinstance(var, types.ListType) and isinstance(var, types.StringType)
Csaba Osztrogonác
Comment 4
2013-04-16 04:41:51 PDT
Or we should recommend always using lists.
Ryosuke Niwa
Comment 5
2013-04-16 10:34:33 PDT
(In reply to
comment #4
)
> Or we should recommend always using lists.
Let’s do that.
Ryosuke Niwa
Comment 6
2013-04-16 10:34:52 PDT
Created
attachment 198344
[details]
Always use emails and nicks
Ryosuke Niwa
Comment 7
2013-04-16 11:39:47 PDT
Committed
r148527
: <
http://trac.webkit.org/changeset/148527
>
Glenn Adams
Comment 8
2013-04-16 22:20:06 PDT
I notice that completion no longer works in BZ's CC, Assigned To etc, which may have to do with this patch.
Ryosuke Niwa
Comment 9
2013-04-16 22:21:52 PDT
(In reply to
comment #8
)
> I notice that completion no longer works in BZ's CC, Assigned To etc, which may have to do with this patch.
Clear the cache.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug