Bug 114673 - The list of contributors in committers.py should be a separate JSON
Summary: The list of contributors in committers.py should be a separate JSON
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on: 114671
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-16 02:14 PDT by Ryosuke Niwa
Modified: 2013-04-16 22:21 PDT (History)
9 users (show)

See Also:


Attachments
Cleanup (92.32 KB, patch)
2013-04-16 03:29 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Always use emails and nicks (94.09 KB, patch)
2013-04-16 10:34 PDT, Ryosuke Niwa
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-04-16 02:14:46 PDT
We should extract the list of contributors, committers, and reviewers into a JSON file.
There’s no point in forcing everyone to read through Python code.
Comment 1 Ryosuke Niwa 2013-04-16 02:15:38 PDT
This will also allow Bugzilla and other websites and tools to parse the list of contributors in JavaScript more easily.
Comment 2 Ryosuke Niwa 2013-04-16 03:29:30 PDT
Created attachment 198315 [details]
Cleanup
Comment 3 Csaba Osztrogonác 2013-04-16 04:12:46 PDT
Comment on attachment 198315 [details]
Cleanup

LGTM, but using email/email and nick/nicks in the JSON is a little bit strange for me.
I prefer a simpler syntax, only email and nick. It is so easy to check if an instance
is a string or a list: isinstance(var, types.ListType) and isinstance(var, types.StringType)
Comment 4 Csaba Osztrogonác 2013-04-16 04:41:51 PDT
Or we should recommend always using lists.
Comment 5 Ryosuke Niwa 2013-04-16 10:34:33 PDT
(In reply to comment #4)
> Or we should recommend always using lists.

Let’s do that.
Comment 6 Ryosuke Niwa 2013-04-16 10:34:52 PDT
Created attachment 198344 [details]
Always use emails and nicks
Comment 7 Ryosuke Niwa 2013-04-16 11:39:47 PDT
Committed r148527: <http://trac.webkit.org/changeset/148527>
Comment 8 Glenn Adams 2013-04-16 22:20:06 PDT
I notice that completion no longer works in BZ's CC, Assigned To etc, which may have to do with this patch.
Comment 9 Ryosuke Niwa 2013-04-16 22:21:52 PDT
(In reply to comment #8)
> I notice that completion no longer works in BZ's CC, Assigned To etc, which may have to do with this patch.

Clear the cache.