Bug 114650 – WebKit should not decode or support PDF favicons

• Status: RESOLVED
• Resolution: FIXED
• Component: Images

[Tim Horton]

No other browser I can find supports this anyway. *We* don't even successfully display the image, but we try to.

<rdar://problem/10133914>

[Tim Horton]

Created attachment 198207 [details]
patch

Not sure if this is a reasonable place to bail if we find PDF data, but... maybe?

[WebKit Commit Bot]

Attachment 198207 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/loader/icon/IconLoader.cpp']" exit_code: 1
Source/WebCore/loader/icon/IconLoader.cpp:100:  Omit int when using unsigned  [runtime/unsigned] [1]
Source/WebCore/loader/icon/IconLoader.cpp:104:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Created attachment 198208 [details]
patch

[Tim Horton]

Created attachment 198209 [details]
patch

[Tim Horton]

Created attachment 198210 [details]
patch

oh boy

Comment on attachment 198210 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198210&action=review

> Source/WebCore/loader/icon/IconLoader.cpp:100
> +    static const char* pdfMagicNumber = "%PDF";
> +    static unsigned pdfMagicNumberLength = strlen(pdfMagicNumber);

I would have done this with a uint32_t constant (and gotten it wrong on big endian) or a char array that I could sizeof() instead of using strlen().

[Tim Horton]

http://trac.webkit.org/changeset/148758