Bug 114642 – Remove more #includes from Frame.h

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Remove more #includes from Frame.h

[Sam Weinig]

Created attachment 198190 [details]
Patch

[WebKit Commit Bot]

Attachment 198190 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/AXObjectCache.cpp', u'Source/WebCore/accessibility/AccessibilityObject.cpp', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/dom/CharacterData.cpp', u'Source/WebCore/dom/ContainerNode.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/editing/AlternativeTextController.cpp', u'Source/WebCore/editing/CompositeEditCommand.cpp', u'Source/WebCore/editing/DeleteButtonController.h', u'Source/WebCore/editing/EditingStyle.cpp', u'Source/WebCore/editing/InsertLineBreakCommand.cpp', u'Source/WebCore/editing/SpellChecker.cpp', u'Source/WebCore/editing/SpellingCorrectionCommand.cpp', u'Source/WebCore/editing/TextInsertionBaseCommand.cpp', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/html/HTMLAnchorElement.cpp', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/HTMLSelectElement.cpp', u'Source/WebCore/html/HTMLTextAreaElement.cpp', u'Source/WebCore/html/HTMLTextFormControlElement.cpp', u'Source/WebCore/html/TextFieldInputType.cpp', u'Source/WebCore/html/shadow/ClearButtonElement.cpp', u'Source/WebCore/html/shadow/MediaControlElements.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/inspector/InspectorPageAgent.h', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/FrameView.h', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm', u'Source/WebCore/rendering/HitTestResult.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderNamedFlowThread.cpp', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp', u'Source/WebCore/svg/graphics/SVGImage.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebHTMLRepresentation.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebPage/WebFrame.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm']" exit_code: 1
Source/WebCore/page/Frame.h:55:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/editing/DeleteButtonController.h:33:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/history/CachedFrame.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 3 in 55 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 198190 [details]
Patch

Attachment 198190 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/220

[Early Warning System Bot]

Comment on attachment 198190 [details]
Patch

Attachment 198190 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-queues.appspot.com/results/30428

[EFL EWS Bot]

Comment on attachment 198190 [details]
Patch

Attachment 198190 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/139367

[Sam Weinig]

Created attachment 198194 [details]
Patch

[WebKit Commit Bot]

Attachment 198194 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/AXObjectCache.cpp', u'Source/WebCore/accessibility/AccessibilityObject.cpp', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/dom/CharacterData.cpp', u'Source/WebCore/dom/ContainerNode.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/editing/AlternativeTextController.cpp', u'Source/WebCore/editing/CompositeEditCommand.cpp', u'Source/WebCore/editing/DeleteButtonController.h', u'Source/WebCore/editing/EditingStyle.cpp', u'Source/WebCore/editing/InsertLineBreakCommand.cpp', u'Source/WebCore/editing/SpellChecker.cpp', u'Source/WebCore/editing/SpellingCorrectionCommand.cpp', u'Source/WebCore/editing/TextInsertionBaseCommand.cpp', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/html/HTMLAnchorElement.cpp', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/HTMLSelectElement.cpp', u'Source/WebCore/html/HTMLTextAreaElement.cpp', u'Source/WebCore/html/HTMLTextFormControlElement.cpp', u'Source/WebCore/html/TextFieldInputType.cpp', u'Source/WebCore/html/shadow/ClearButtonElement.cpp', u'Source/WebCore/html/shadow/MediaControlElements.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/inspector/InspectorPageAgent.h', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/FrameView.h', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/TouchAdjustment.cpp', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm', u'Source/WebCore/rendering/HitTestResult.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderNamedFlowThread.cpp', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp', u'Source/WebCore/svg/graphics/SVGImage.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebHTMLRepresentation.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebPage/WebFrame.cpp', u'Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm', u'Source/WebKit2/WebProcess/WebPage/qt/WebPageQt.cpp']" exit_code: 1
Source/WebCore/page/Frame.h:55:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/history/CachedFrame.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 58 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EFL EWS Bot]

Comment on attachment 198194 [details]
Patch

Attachment 198194 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/161253

[Early Warning System Bot]

Comment on attachment 198194 [details]
Patch

Attachment 198194 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/30436

[Early Warning System Bot]

Comment on attachment 198194 [details]
Patch

Attachment 198194 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-queues.appspot.com/results/30437

[Alexey Proskuryakov]

Comment on attachment 198194 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198194&action=review

> Source/WebCore/page/Frame.h:226
> -        mutable Editor m_editor;
> -        mutable FrameSelection m_selection;
> -        mutable EventHandler m_eventHandler;
> -        mutable AnimationController m_animationController;
> +        OwnPtr<Editor> m_editor;
> +        OwnPtr<FrameSelection> m_selection;
> +        OwnPtr<EventHandler> m_eventHandler;
> +        OwnPtr<AnimationController> m_animationController;

These all seem like they can be on hot paths. How did you measure performance?

[Sam Weinig]

(In reply to comment #11)
> (From update of attachment 198194 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=198194&action=review
> 
> > Source/WebCore/page/Frame.h:226
> > -        mutable Editor m_editor;
> > -        mutable FrameSelection m_selection;
> > -        mutable EventHandler m_eventHandler;
> > -        mutable AnimationController m_animationController;
> > +        OwnPtr<Editor> m_editor;
> > +        OwnPtr<FrameSelection> m_selection;
> > +        OwnPtr<EventHandler> m_eventHandler;
> > +        OwnPtr<AnimationController> m_animationController;
> 
> These all seem like they can be on hot paths. How did you measure performance?

I converted these from pointers to direct members long ago and I think it was the wrong choice.  If there is a PLT issue, I will reconsider, but I think we could do local caching if it really is an issue.

[Sam Weinig]

Created attachment 198203 [details]
Patch

[WebKit Commit Bot]

Attachment 198203 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/AXObjectCache.cpp', u'Source/WebCore/accessibility/AccessibilityObject.cpp', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/dom/CharacterData.cpp', u'Source/WebCore/dom/ContainerNode.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/editing/AlternativeTextController.cpp', u'Source/WebCore/editing/CompositeEditCommand.cpp', u'Source/WebCore/editing/DeleteButtonController.h', u'Source/WebCore/editing/EditingStyle.cpp', u'Source/WebCore/editing/InsertLineBreakCommand.cpp', u'Source/WebCore/editing/SpellChecker.cpp', u'Source/WebCore/editing/SpellingCorrectionCommand.cpp', u'Source/WebCore/editing/TextInsertionBaseCommand.cpp', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/html/HTMLAnchorElement.cpp', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/HTMLSelectElement.cpp', u'Source/WebCore/html/HTMLTextAreaElement.cpp', u'Source/WebCore/html/HTMLTextFormControlElement.cpp', u'Source/WebCore/html/TextFieldInputType.cpp', u'Source/WebCore/html/shadow/ClearButtonElement.cpp', u'Source/WebCore/html/shadow/MediaControlElements.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/inspector/InspectorPageAgent.h', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/FrameView.h', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/TouchAdjustment.cpp', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm', u'Source/WebCore/platform/gtk/PasteboardGtk.cpp', u'Source/WebCore/platform/qt/ClipboardQt.cpp', u'Source/WebCore/rendering/HitTestResult.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderNamedFlowThread.cpp', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp', u'Source/WebCore/svg/graphics/SVGImage.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebHTMLRepresentation.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebPage/WebFrame.cpp', u'Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm', u'Source/WebKit2/WebProcess/WebPage/qt/WebPageQt.cpp']" exit_code: 1
Source/WebCore/page/Frame.h:55:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/history/CachedFrame.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 60 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 198203 [details]
Patch

Attachment 198203 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/69198

[Early Warning System Bot]

Comment on attachment 198203 [details]
Patch

Attachment 198203 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-queues.appspot.com/results/133144

[EFL EWS Bot]

Comment on attachment 198203 [details]
Patch

Attachment 198203 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/94105

[Build Bot]

Comment on attachment 198203 [details]
Patch

Attachment 198203 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/89383

New failing tests:
platform/mac/editing/spelling/click-autocorrected-word.html
platform/mac/editing/spelling/autocorrection-blockquote-crash.html
platform/mac/editing/spelling/delete-into-autocorrected-word.html
platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html
editing/inserting/typing-space-to-trigger-smart-link.html
platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html
platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html
platform/mac/editing/spelling/editing-word-with-marker-1.html
editing/spelling/grammar.html
platform/mac/editing/spelling/autocorrection-with-multi-line-text.html
editing/spelling/markers.html
platform/mac/editing/spelling/autocorrection-contraction.html
platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html

[Build Bot]

Created attachment 198213 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.2

[Sam Weinig]

Created attachment 198214 [details]
Patch

[WebKit Commit Bot]

Attachment 198214 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/AXObjectCache.cpp', u'Source/WebCore/accessibility/AccessibilityObject.cpp', u'Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceEditableText.cpp', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/dom/CharacterData.cpp', u'Source/WebCore/dom/ContainerNode.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/editing/AlternativeTextController.cpp', u'Source/WebCore/editing/CompositeEditCommand.cpp', u'Source/WebCore/editing/DeleteButtonController.h', u'Source/WebCore/editing/EditingStyle.cpp', u'Source/WebCore/editing/InsertLineBreakCommand.cpp', u'Source/WebCore/editing/SpellChecker.cpp', u'Source/WebCore/editing/SpellingCorrectionCommand.cpp', u'Source/WebCore/editing/TextInsertionBaseCommand.cpp', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/html/HTMLAnchorElement.cpp', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/HTMLSelectElement.cpp', u'Source/WebCore/html/HTMLTextAreaElement.cpp', u'Source/WebCore/html/HTMLTextFormControlElement.cpp', u'Source/WebCore/html/TextFieldInputType.cpp', u'Source/WebCore/html/shadow/ClearButtonElement.cpp', u'Source/WebCore/html/shadow/MediaControlElements.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/inspector/InspectorPageAgent.h', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/FrameView.h', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/TouchAdjustment.cpp', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm', u'Source/WebCore/platform/gtk/PasteboardGtk.cpp', u'Source/WebCore/platform/qt/ClipboardQt.cpp', u'Source/WebCore/rendering/HitTestResult.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderNamedFlowThread.cpp', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp', u'Source/WebCore/svg/graphics/SVGImage.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebHTMLRepresentation.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/qt/WebCoreSupport/DragClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebPage/WebFrame.cpp', u'Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm', u'Source/WebKit2/WebProcess/WebPage/qt/WebPageQt.cpp']" exit_code: 1
Source/WebCore/page/Frame.h:55:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/history/CachedFrame.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 64 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 198214 [details]
Patch

Attachment 198214 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/13065

[Early Warning System Bot]

Comment on attachment 198214 [details]
Patch

Attachment 198214 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-queues.appspot.com/results/13066

[EFL EWS Bot]

Comment on attachment 198214 [details]
Patch

Attachment 198214 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/46493

[Sam Weinig]

Created attachment 198223 [details]
Patch

[WebKit Commit Bot]

Attachment 198223 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/AXObjectCache.cpp', u'Source/WebCore/accessibility/AccessibilityObject.cpp', u'Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceEditableText.cpp', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/dom/CharacterData.cpp', u'Source/WebCore/dom/ContainerNode.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/editing/AlternativeTextController.cpp', u'Source/WebCore/editing/CompositeEditCommand.cpp', u'Source/WebCore/editing/DeleteButtonController.h', u'Source/WebCore/editing/EditingStyle.cpp', u'Source/WebCore/editing/InsertLineBreakCommand.cpp', u'Source/WebCore/editing/SpellChecker.cpp', u'Source/WebCore/editing/SpellingCorrectionCommand.cpp', u'Source/WebCore/editing/TextInsertionBaseCommand.cpp', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/html/HTMLAnchorElement.cpp', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/HTMLSelectElement.cpp', u'Source/WebCore/html/HTMLTextAreaElement.cpp', u'Source/WebCore/html/HTMLTextFormControlElement.cpp', u'Source/WebCore/html/TextFieldInputType.cpp', u'Source/WebCore/html/shadow/ClearButtonElement.cpp', u'Source/WebCore/html/shadow/MediaControlElements.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/inspector/InspectorPageAgent.h', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/FrameView.h', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/TouchAdjustment.cpp', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm', u'Source/WebCore/platform/gtk/PasteboardGtk.cpp', u'Source/WebCore/platform/qt/ClipboardQt.cpp', u'Source/WebCore/rendering/HitTestResult.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderNamedFlowThread.cpp', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp', u'Source/WebCore/svg/graphics/SVGImage.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebHTMLRepresentation.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/qt/WebCoreSupport/DragClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebPage/WebFrame.cpp', u'Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm', u'Source/WebKit2/WebProcess/WebPage/qt/WebPageQt.cpp']" exit_code: 1
Source/WebCore/page/Frame.h:55:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/history/CachedFrame.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 65 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EFL EWS Bot]

Comment on attachment 198223 [details]
Patch

Attachment 198223 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/166019

[Sam Weinig]

Created attachment 198232 [details]
Patch

[WebKit Commit Bot]

Attachment 198232 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/AXObjectCache.cpp', u'Source/WebCore/accessibility/AccessibilityObject.cpp', u'Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceEditableText.cpp', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/dom/CharacterData.cpp', u'Source/WebCore/dom/ContainerNode.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/editing/AlternativeTextController.cpp', u'Source/WebCore/editing/CompositeEditCommand.cpp', u'Source/WebCore/editing/DeleteButtonController.h', u'Source/WebCore/editing/EditingStyle.cpp', u'Source/WebCore/editing/InsertLineBreakCommand.cpp', u'Source/WebCore/editing/SpellChecker.cpp', u'Source/WebCore/editing/SpellingCorrectionCommand.cpp', u'Source/WebCore/editing/TextInsertionBaseCommand.cpp', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/html/HTMLAnchorElement.cpp', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/HTMLSelectElement.cpp', u'Source/WebCore/html/HTMLTextAreaElement.cpp', u'Source/WebCore/html/HTMLTextFormControlElement.cpp', u'Source/WebCore/html/TextFieldInputType.cpp', u'Source/WebCore/html/shadow/ClearButtonElement.cpp', u'Source/WebCore/html/shadow/MediaControlElements.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/inspector/InspectorPageAgent.h', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/FrameView.h', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/TouchAdjustment.cpp', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm', u'Source/WebCore/platform/gtk/PasteboardGtk.cpp', u'Source/WebCore/platform/qt/ClipboardQt.cpp', u'Source/WebCore/rendering/HitTestResult.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderNamedFlowThread.cpp', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp', u'Source/WebCore/svg/graphics/SVGImage.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebHTMLRepresentation.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/qt/ChangeLog', u'Source/WebKit/qt/WebCoreSupport/DragClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebPage/WebFrame.cpp', u'Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm', u'Source/WebKit2/WebProcess/WebPage/qt/WebPageQt.cpp']" exit_code: 1
Source/WebCore/page/Frame.h:55:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/history/CachedFrame.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 66 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EFL EWS Bot]

Comment on attachment 198232 [details]
Patch

Attachment 198232 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/62215

[Build Bot]

Comment on attachment 198232 [details]
Patch

Attachment 198232 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/104260

New failing tests:
platform/mac/accessibility/misspelled-attributed-string.html

[Build Bot]

Created attachment 198267 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2

[kov's GTK+ EWS bot]

Comment on attachment 198232 [details]
Patch

Attachment 198232 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/49453

[Build Bot]

Comment on attachment 198232 [details]
Patch

Attachment 198232 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/15231

New failing tests:
platform/mac/editing/spelling/click-autocorrected-word.html
platform/mac/editing/spelling/autocorrection-blockquote-crash.html
platform/mac/editing/spelling/delete-into-autocorrected-word.html
platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html
editing/inserting/typing-space-to-trigger-smart-link.html
platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html
platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html
platform/mac/editing/spelling/editing-word-with-marker-1.html
editing/spelling/grammar.html
platform/mac/editing/spelling/autocorrection-with-multi-line-text.html
editing/spelling/markers.html
platform/mac/editing/spelling/autocorrection-contraction.html
platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html

[Build Bot]

Created attachment 198271 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.2

[Sam Weinig]

Committed r148545: <http://trac.webkit.org/changeset/148545>

[Ryosuke Niwa]

It seems like this patch broke spellchecking tests:
http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK1%20%28Tests%29/builds/9123

http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK1%20%28Tests%29/builds/9124

[Jessie Berlin]

(In reply to comment #36)
> Committed r148545: <http://trac.webkit.org/changeset/148545>

This broke exactly the editing tests that the EWS system pointed out that it would break:

http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r148545%20(11585)/results.html
http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r148545%20(9124)/results.html

[Jessie Berlin]

(In reply to comment #38)
> (In reply to comment #36)
> > Committed r148545: <http://trac.webkit.org/changeset/148545>
> 
> This broke exactly the editing tests that the EWS system pointed out that it would break:
> 
> http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r148545%20(11585)/results.html
> http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r148545%20(9124)/results.html

Anders said he would take a look at these failures.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 114711

[Jessie Berlin]

(In reply to comment #40)
> Re-opened since this is blocked by bug 114711

For those watching at home Sam is also looking into the assertion failures caused by this patch:

Application Specific Information:
CRASHING TEST: fast/forms/search-event-delay.html
objc[82067]: garbage collection is OFF

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.WebCore             	0x00000001117aca4a WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges(unsigned int, WebCore::Range*, WebCore::Range*) + 186 (Editor.cpp:2094)
1   com.apple.WebCore             	0x0000000111217773 WebCore::AlternativeTextController::timerFired(WebCore::Timer<WebCore::AlternativeTextController>*) + 307 (AlternativeTextController.cpp:342)
2   com.apple.WebCore             	0x000000011121d213 WebCore::Timer<WebCore::AlternativeTextController>::fired() + 115 (Timer.h:113)
3   com.apple.WebCore             	0x0000000112c5175e WebCore::ThreadTimers::sharedTimerFiredInternal() + 302 (ThreadTimers.cpp:132)
4   com.apple.WebCore             	0x0000000112c51479 WebCore::ThreadTimers::sharedTimerFired() + 25 (ThreadTimers.cpp:106)
5   com.apple.WebCore             	0x00000001129827e3 _ZN7WebCoreL10timerFiredEP16__CFRunLoopTimerPv + 67 (SharedTimerMac.mm:140)
6   com.apple.CoreFoundation      	0x00007fff841d7934 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 20
7   com.apple.CoreFoundation      	0x00007fff841d7486 __CFRunLoopDoTimer + 534
8   com.apple.CoreFoundation      	0x00007fff841b7e11 __CFRunLoopRun + 1617
9   com.apple.CoreFoundation      	0x00007fff841b7486 CFRunLoopRunSpecific + 230
10  com.apple.Foundation          	0x00007fff846c5f7b -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 267
11  DumpRenderTree                	0x000000010f719709 _ZL7runTestRKNSt3__112basic_stringIcNS_11char_traitsIcEENS_9allocatorIcEEEE + 5017 (DumpRenderTree.mm:1384)
12  DumpRenderTree                	0x000000010f7182fa _ZL20runTestingServerLoopv + 282 (DumpRenderTree.mm:844)
13  DumpRenderTree                	0x000000010f717cf5 dumpRenderTree(int, char const**) + 405 (DumpRenderTree.mm:899)
14  DumpRenderTree                	0x000000010f719ef9 main + 105 (DumpRenderTree.mm:937)
15  DumpRenderTree                	0x000000010f702224 start + 52

[Sam Weinig]

Fixed in http://trac.webkit.org/changeset/148584.