114642 – Remove more #includes from Frame.h

Bug 114642 - Remove more #includes from Frame.h

Summary: Remove more #includes from Frame.h

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Sam Weinig

URL:
Keywords:

Depends on:	114711
Blocks:
	Show dependency tree / graph

Reported:	2013-04-15 14:51 PDT by Sam Weinig
Modified:	2013-04-16 18:22 PDT (History)
CC List:	30 users (show)

See Also:

Attachments
Patch (38.33 KB, patch) 2013-04-15 14:52 PDT, Sam Weinig	no flags	Details \| Formatted Diff \| Diff
Patch (39.74 KB, patch) 2013-04-15 15:54 PDT, Sam Weinig	no flags	Details \| Formatted Diff \| Diff
Patch (40.60 KB, patch) 2013-04-15 16:51 PDT, Sam Weinig	no flags	Details \| Formatted Diff \| Diff
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (1.68 MB, application/zip) 2013-04-15 18:17 PDT, Build Bot	no flags	Details
Patch (43.12 KB, patch) 2013-04-15 18:22 PDT, Sam Weinig	no flags	Details \| Formatted Diff \| Diff
Patch (43.59 KB, patch) 2013-04-15 19:39 PDT, Sam Weinig	no flags	Details \| Formatted Diff \| Diff
Patch (44.68 KB, patch) 2013-04-15 21:23 PDT, Sam Weinig	andersca: review+ eflews.bot: commit-queue-	Details \| Formatted Diff \| Diff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (553.37 KB, application/zip) 2013-04-15 23:38 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion (1.69 MB, application/zip) 2013-04-16 00:44 PDT, Build Bot	no flags	Details
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Sam Weinig 2013-04-15 14:51:36 PDT

Remove more #includes from Frame.h

Comment 1 Sam Weinig 2013-04-15 14:52:44 PDT

Created attachment 198190 [details]
Patch

Comment 2 WebKit Commit Bot 2013-04-15 14:56:00 PDT

Attachment 198190 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/AXObjectCache.cpp', u'Source/WebCore/accessibility/AccessibilityObject.cpp', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/dom/CharacterData.cpp', u'Source/WebCore/dom/ContainerNode.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/editing/AlternativeTextController.cpp', u'Source/WebCore/editing/CompositeEditCommand.cpp', u'Source/WebCore/editing/DeleteButtonController.h', u'Source/WebCore/editing/EditingStyle.cpp', u'Source/WebCore/editing/InsertLineBreakCommand.cpp', u'Source/WebCore/editing/SpellChecker.cpp', u'Source/WebCore/editing/SpellingCorrectionCommand.cpp', u'Source/WebCore/editing/TextInsertionBaseCommand.cpp', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/html/HTMLAnchorElement.cpp', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/HTMLSelectElement.cpp', u'Source/WebCore/html/HTMLTextAreaElement.cpp', u'Source/WebCore/html/HTMLTextFormControlElement.cpp', u'Source/WebCore/html/TextFieldInputType.cpp', u'Source/WebCore/html/shadow/ClearButtonElement.cpp', u'Source/WebCore/html/shadow/MediaControlElements.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/inspector/InspectorPageAgent.h', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/FrameView.h', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm', u'Source/WebCore/rendering/HitTestResult.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderNamedFlowThread.cpp', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp', u'Source/WebCore/svg/graphics/SVGImage.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebHTMLRepresentation.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebPage/WebFrame.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm']" exit_code: 1
Source/WebCore/page/Frame.h:55:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/editing/DeleteButtonController.h:33:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/history/CachedFrame.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 3 in 55 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Early Warning System Bot 2013-04-15 15:00:01 PDT

Comment on attachment 198190 [details]
Patch

Attachment 198190 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/220

Comment 4 Early Warning System Bot 2013-04-15 15:01:27 PDT

Comment on attachment 198190 [details]
Patch

Attachment 198190 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-queues.appspot.com/results/30428

Comment 5 EFL EWS Bot 2013-04-15 15:16:46 PDT

Comment on attachment 198190 [details]
Patch

Attachment 198190 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/139367

Comment 6 Sam Weinig 2013-04-15 15:54:26 PDT

Created attachment 198194 [details]
Patch

Comment 7 WebKit Commit Bot 2013-04-15 15:57:00 PDT

Attachment 198194 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/AXObjectCache.cpp', u'Source/WebCore/accessibility/AccessibilityObject.cpp', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/dom/CharacterData.cpp', u'Source/WebCore/dom/ContainerNode.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/editing/AlternativeTextController.cpp', u'Source/WebCore/editing/CompositeEditCommand.cpp', u'Source/WebCore/editing/DeleteButtonController.h', u'Source/WebCore/editing/EditingStyle.cpp', u'Source/WebCore/editing/InsertLineBreakCommand.cpp', u'Source/WebCore/editing/SpellChecker.cpp', u'Source/WebCore/editing/SpellingCorrectionCommand.cpp', u'Source/WebCore/editing/TextInsertionBaseCommand.cpp', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/html/HTMLAnchorElement.cpp', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/HTMLSelectElement.cpp', u'Source/WebCore/html/HTMLTextAreaElement.cpp', u'Source/WebCore/html/HTMLTextFormControlElement.cpp', u'Source/WebCore/html/TextFieldInputType.cpp', u'Source/WebCore/html/shadow/ClearButtonElement.cpp', u'Source/WebCore/html/shadow/MediaControlElements.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/inspector/InspectorPageAgent.h', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/FrameView.h', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/TouchAdjustment.cpp', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm', u'Source/WebCore/rendering/HitTestResult.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderNamedFlowThread.cpp', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp', u'Source/WebCore/svg/graphics/SVGImage.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebHTMLRepresentation.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebPage/WebFrame.cpp', u'Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm', u'Source/WebKit2/WebProcess/WebPage/qt/WebPageQt.cpp']" exit_code: 1
Source/WebCore/page/Frame.h:55:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/history/CachedFrame.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 58 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 8 EFL EWS Bot 2013-04-15 16:02:38 PDT

Comment on attachment 198194 [details]
Patch

Attachment 198194 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/161253

Comment 9 Early Warning System Bot 2013-04-15 16:06:07 PDT

Comment on attachment 198194 [details]
Patch

Attachment 198194 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/30436

Comment 10 Early Warning System Bot 2013-04-15 16:08:56 PDT

Comment on attachment 198194 [details]
Patch

Attachment 198194 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-queues.appspot.com/results/30437

Comment 11 Alexey Proskuryakov 2013-04-15 16:39:53 PDT

Comment on attachment 198194 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198194&action=review

> Source/WebCore/page/Frame.h:226
> -        mutable Editor m_editor;
> -        mutable FrameSelection m_selection;
> -        mutable EventHandler m_eventHandler;
> -        mutable AnimationController m_animationController;
> +        OwnPtr<Editor> m_editor;
> +        OwnPtr<FrameSelection> m_selection;
> +        OwnPtr<EventHandler> m_eventHandler;
> +        OwnPtr<AnimationController> m_animationController;

These all seem like they can be on hot paths. How did you measure performance?

Comment 12 Sam Weinig 2013-04-15 16:46:03 PDT

(In reply to comment #11)
> (From update of attachment 198194 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=198194&action=review
> 
> > Source/WebCore/page/Frame.h:226
> > -        mutable Editor m_editor;
> > -        mutable FrameSelection m_selection;
> > -        mutable EventHandler m_eventHandler;
> > -        mutable AnimationController m_animationController;
> > +        OwnPtr<Editor> m_editor;
> > +        OwnPtr<FrameSelection> m_selection;
> > +        OwnPtr<EventHandler> m_eventHandler;
> > +        OwnPtr<AnimationController> m_animationController;
> 
> These all seem like they can be on hot paths. How did you measure performance?

I converted these from pointers to direct members long ago and I think it was the wrong choice.  If there is a PLT issue, I will reconsider, but I think we could do local caching if it really is an issue.

Comment 13 Sam Weinig 2013-04-15 16:51:30 PDT

Created attachment 198203 [details]
Patch

Comment 14 WebKit Commit Bot 2013-04-15 16:52:39 PDT

Attachment 198203 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/AXObjectCache.cpp', u'Source/WebCore/accessibility/AccessibilityObject.cpp', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/dom/CharacterData.cpp', u'Source/WebCore/dom/ContainerNode.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/editing/AlternativeTextController.cpp', u'Source/WebCore/editing/CompositeEditCommand.cpp', u'Source/WebCore/editing/DeleteButtonController.h', u'Source/WebCore/editing/EditingStyle.cpp', u'Source/WebCore/editing/InsertLineBreakCommand.cpp', u'Source/WebCore/editing/SpellChecker.cpp', u'Source/WebCore/editing/SpellingCorrectionCommand.cpp', u'Source/WebCore/editing/TextInsertionBaseCommand.cpp', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/html/HTMLAnchorElement.cpp', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/HTMLSelectElement.cpp', u'Source/WebCore/html/HTMLTextAreaElement.cpp', u'Source/WebCore/html/HTMLTextFormControlElement.cpp', u'Source/WebCore/html/TextFieldInputType.cpp', u'Source/WebCore/html/shadow/ClearButtonElement.cpp', u'Source/WebCore/html/shadow/MediaControlElements.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/inspector/InspectorPageAgent.h', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/FrameView.h', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/TouchAdjustment.cpp', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm', u'Source/WebCore/platform/gtk/PasteboardGtk.cpp', u'Source/WebCore/platform/qt/ClipboardQt.cpp', u'Source/WebCore/rendering/HitTestResult.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderNamedFlowThread.cpp', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp', u'Source/WebCore/svg/graphics/SVGImage.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebHTMLRepresentation.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebPage/WebFrame.cpp', u'Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm', u'Source/WebKit2/WebProcess/WebPage/qt/WebPageQt.cpp']" exit_code: 1
Source/WebCore/page/Frame.h:55:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/history/CachedFrame.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 60 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 15 Early Warning System Bot 2013-04-15 17:13:10 PDT

Comment on attachment 198203 [details]
Patch

Attachment 198203 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/69198

Comment 16 Early Warning System Bot 2013-04-15 17:24:41 PDT

Comment on attachment 198203 [details]
Patch

Attachment 198203 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-queues.appspot.com/results/133144

Comment 17 EFL EWS Bot 2013-04-15 17:24:51 PDT

Comment on attachment 198203 [details]
Patch

Attachment 198203 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/94105

Comment 18 Build Bot 2013-04-15 18:17:11 PDT

Comment on attachment 198203 [details]
Patch

Attachment 198203 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/89383

New failing tests:
platform/mac/editing/spelling/click-autocorrected-word.html
platform/mac/editing/spelling/autocorrection-blockquote-crash.html
platform/mac/editing/spelling/delete-into-autocorrected-word.html
platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html
editing/inserting/typing-space-to-trigger-smart-link.html
platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html
platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html
platform/mac/editing/spelling/editing-word-with-marker-1.html
editing/spelling/grammar.html
platform/mac/editing/spelling/autocorrection-with-multi-line-text.html
editing/spelling/markers.html
platform/mac/editing/spelling/autocorrection-contraction.html
platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html

Comment 19 Build Bot 2013-04-15 18:17:14 PDT

Created attachment 198213 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.2

Comment 20 Sam Weinig 2013-04-15 18:22:08 PDT

Created attachment 198214 [details]
Patch

Comment 21 WebKit Commit Bot 2013-04-15 18:24:26 PDT

Attachment 198214 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/AXObjectCache.cpp', u'Source/WebCore/accessibility/AccessibilityObject.cpp', u'Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceEditableText.cpp', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/dom/CharacterData.cpp', u'Source/WebCore/dom/ContainerNode.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/editing/AlternativeTextController.cpp', u'Source/WebCore/editing/CompositeEditCommand.cpp', u'Source/WebCore/editing/DeleteButtonController.h', u'Source/WebCore/editing/EditingStyle.cpp', u'Source/WebCore/editing/InsertLineBreakCommand.cpp', u'Source/WebCore/editing/SpellChecker.cpp', u'Source/WebCore/editing/SpellingCorrectionCommand.cpp', u'Source/WebCore/editing/TextInsertionBaseCommand.cpp', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/html/HTMLAnchorElement.cpp', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/HTMLSelectElement.cpp', u'Source/WebCore/html/HTMLTextAreaElement.cpp', u'Source/WebCore/html/HTMLTextFormControlElement.cpp', u'Source/WebCore/html/TextFieldInputType.cpp', u'Source/WebCore/html/shadow/ClearButtonElement.cpp', u'Source/WebCore/html/shadow/MediaControlElements.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/inspector/InspectorPageAgent.h', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/FrameView.h', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/TouchAdjustment.cpp', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm', u'Source/WebCore/platform/gtk/PasteboardGtk.cpp', u'Source/WebCore/platform/qt/ClipboardQt.cpp', u'Source/WebCore/rendering/HitTestResult.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderNamedFlowThread.cpp', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp', u'Source/WebCore/svg/graphics/SVGImage.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebHTMLRepresentation.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/qt/WebCoreSupport/DragClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebPage/WebFrame.cpp', u'Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm', u'Source/WebKit2/WebProcess/WebPage/qt/WebPageQt.cpp']" exit_code: 1
Source/WebCore/page/Frame.h:55:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/history/CachedFrame.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 64 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 22 Early Warning System Bot 2013-04-15 18:38:55 PDT

Comment on attachment 198214 [details]
Patch

Attachment 198214 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/13065

Comment 23 Early Warning System Bot 2013-04-15 18:50:39 PDT

Comment on attachment 198214 [details]
Patch

Attachment 198214 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-queues.appspot.com/results/13066

Comment 24 EFL EWS Bot 2013-04-15 18:59:31 PDT

Comment on attachment 198214 [details]
Patch

Attachment 198214 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/46493

Comment 25 Sam Weinig 2013-04-15 19:39:39 PDT

Created attachment 198223 [details]
Patch

Comment 26 WebKit Commit Bot 2013-04-15 19:42:01 PDT

Attachment 198223 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/AXObjectCache.cpp', u'Source/WebCore/accessibility/AccessibilityObject.cpp', u'Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceEditableText.cpp', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/dom/CharacterData.cpp', u'Source/WebCore/dom/ContainerNode.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/editing/AlternativeTextController.cpp', u'Source/WebCore/editing/CompositeEditCommand.cpp', u'Source/WebCore/editing/DeleteButtonController.h', u'Source/WebCore/editing/EditingStyle.cpp', u'Source/WebCore/editing/InsertLineBreakCommand.cpp', u'Source/WebCore/editing/SpellChecker.cpp', u'Source/WebCore/editing/SpellingCorrectionCommand.cpp', u'Source/WebCore/editing/TextInsertionBaseCommand.cpp', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/html/HTMLAnchorElement.cpp', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/HTMLSelectElement.cpp', u'Source/WebCore/html/HTMLTextAreaElement.cpp', u'Source/WebCore/html/HTMLTextFormControlElement.cpp', u'Source/WebCore/html/TextFieldInputType.cpp', u'Source/WebCore/html/shadow/ClearButtonElement.cpp', u'Source/WebCore/html/shadow/MediaControlElements.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/inspector/InspectorPageAgent.h', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/FrameView.h', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/TouchAdjustment.cpp', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm', u'Source/WebCore/platform/gtk/PasteboardGtk.cpp', u'Source/WebCore/platform/qt/ClipboardQt.cpp', u'Source/WebCore/rendering/HitTestResult.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderNamedFlowThread.cpp', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp', u'Source/WebCore/svg/graphics/SVGImage.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebHTMLRepresentation.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/qt/WebCoreSupport/DragClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebPage/WebFrame.cpp', u'Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm', u'Source/WebKit2/WebProcess/WebPage/qt/WebPageQt.cpp']" exit_code: 1
Source/WebCore/page/Frame.h:55:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/history/CachedFrame.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 65 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 27 EFL EWS Bot 2013-04-15 19:44:56 PDT

Comment on attachment 198223 [details]
Patch

Attachment 198223 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/166019

Comment 28 Sam Weinig 2013-04-15 21:23:51 PDT

Created attachment 198232 [details]
Patch

Comment 29 WebKit Commit Bot 2013-04-15 21:26:27 PDT

Attachment 198232 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/AXObjectCache.cpp', u'Source/WebCore/accessibility/AccessibilityObject.cpp', u'Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceEditableText.cpp', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/dom/CharacterData.cpp', u'Source/WebCore/dom/ContainerNode.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/editing/AlternativeTextController.cpp', u'Source/WebCore/editing/CompositeEditCommand.cpp', u'Source/WebCore/editing/DeleteButtonController.h', u'Source/WebCore/editing/EditingStyle.cpp', u'Source/WebCore/editing/InsertLineBreakCommand.cpp', u'Source/WebCore/editing/SpellChecker.cpp', u'Source/WebCore/editing/SpellingCorrectionCommand.cpp', u'Source/WebCore/editing/TextInsertionBaseCommand.cpp', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/html/HTMLAnchorElement.cpp', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/HTMLSelectElement.cpp', u'Source/WebCore/html/HTMLTextAreaElement.cpp', u'Source/WebCore/html/HTMLTextFormControlElement.cpp', u'Source/WebCore/html/TextFieldInputType.cpp', u'Source/WebCore/html/shadow/ClearButtonElement.cpp', u'Source/WebCore/html/shadow/MediaControlElements.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/inspector/InspectorPageAgent.h', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/FrameView.h', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/TouchAdjustment.cpp', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm', u'Source/WebCore/platform/gtk/PasteboardGtk.cpp', u'Source/WebCore/platform/qt/ClipboardQt.cpp', u'Source/WebCore/rendering/HitTestResult.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderNamedFlowThread.cpp', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp', u'Source/WebCore/svg/graphics/SVGImage.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebHTMLRepresentation.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/qt/ChangeLog', u'Source/WebKit/qt/WebCoreSupport/DragClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebPage/WebFrame.cpp', u'Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm', u'Source/WebKit2/WebProcess/WebPage/qt/WebPageQt.cpp']" exit_code: 1
Source/WebCore/page/Frame.h:55:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/history/CachedFrame.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 66 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 30 EFL EWS Bot 2013-04-15 21:30:13 PDT

Comment on attachment 198232 [details]
Patch

Attachment 198232 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/62215

Comment 31 Build Bot 2013-04-15 23:38:35 PDT

Comment on attachment 198232 [details]
Patch

Attachment 198232 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/104260

New failing tests:
platform/mac/accessibility/misspelled-attributed-string.html

Comment 32 Build Bot 2013-04-15 23:38:41 PDT

Created attachment 198267 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2

Comment 33 kov's GTK+ EWS bot 2013-04-15 23:59:26 PDT

Comment on attachment 198232 [details]
Patch

Attachment 198232 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/49453

Comment 34 Build Bot 2013-04-16 00:44:31 PDT

Comment on attachment 198232 [details]
Patch

Attachment 198232 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/15231

New failing tests:
platform/mac/editing/spelling/click-autocorrected-word.html
platform/mac/editing/spelling/autocorrection-blockquote-crash.html
platform/mac/editing/spelling/delete-into-autocorrected-word.html
platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html
editing/inserting/typing-space-to-trigger-smart-link.html
platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html
platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html
platform/mac/editing/spelling/editing-word-with-marker-1.html
editing/spelling/grammar.html
platform/mac/editing/spelling/autocorrection-with-multi-line-text.html
editing/spelling/markers.html
platform/mac/editing/spelling/autocorrection-contraction.html
platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html

Comment 35 Build Bot 2013-04-16 00:44:36 PDT

Created attachment 198271 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.2

Comment 36 Sam Weinig 2013-04-16 14:52:59 PDT

Committed r148545: <http://trac.webkit.org/changeset/148545>

Comment 37 Ryosuke Niwa 2013-04-16 15:40:40 PDT

It seems like this patch broke spellchecking tests:
http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK1%20%28Tests%29/builds/9123

http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK1%20%28Tests%29/builds/9124

Comment 38 Jessie Berlin 2013-04-16 15:40:49 PDT

(In reply to comment #36)
> Committed r148545: <http://trac.webkit.org/changeset/148545>

This broke exactly the editing tests that the EWS system pointed out that it would break:

http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r148545%20(11585)/results.html
http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r148545%20(9124)/results.html

Comment 39 Jessie Berlin 2013-04-16 15:44:27 PDT

(In reply to comment #38)
> (In reply to comment #36)
> > Committed r148545: <http://trac.webkit.org/changeset/148545>
> 
> This broke exactly the editing tests that the EWS system pointed out that it would break:
> 
> http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r148545%20(11585)/results.html
> http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r148545%20(9124)/results.html

Anders said he would take a look at these failures.

Comment 40 WebKit Commit Bot 2013-04-16 15:46:53 PDT

Re-opened since this is blocked by bug 114711

Comment 41 Jessie Berlin 2013-04-16 16:34:30 PDT

(In reply to comment #40)
> Re-opened since this is blocked by bug 114711

For those watching at home Sam is also looking into the assertion failures caused by this patch:

Application Specific Information:
CRASHING TEST: fast/forms/search-event-delay.html
objc[82067]: garbage collection is OFF

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.WebCore             	0x00000001117aca4a WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges(unsigned int, WebCore::Range*, WebCore::Range*) + 186 (Editor.cpp:2094)
1   com.apple.WebCore             	0x0000000111217773 WebCore::AlternativeTextController::timerFired(WebCore::Timer<WebCore::AlternativeTextController>*) + 307 (AlternativeTextController.cpp:342)
2   com.apple.WebCore             	0x000000011121d213 WebCore::Timer<WebCore::AlternativeTextController>::fired() + 115 (Timer.h:113)
3   com.apple.WebCore             	0x0000000112c5175e WebCore::ThreadTimers::sharedTimerFiredInternal() + 302 (ThreadTimers.cpp:132)
4   com.apple.WebCore             	0x0000000112c51479 WebCore::ThreadTimers::sharedTimerFired() + 25 (ThreadTimers.cpp:106)
5   com.apple.WebCore             	0x00000001129827e3 _ZN7WebCoreL10timerFiredEP16__CFRunLoopTimerPv + 67 (SharedTimerMac.mm:140)
6   com.apple.CoreFoundation      	0x00007fff841d7934 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 20
7   com.apple.CoreFoundation      	0x00007fff841d7486 __CFRunLoopDoTimer + 534
8   com.apple.CoreFoundation      	0x00007fff841b7e11 __CFRunLoopRun + 1617
9   com.apple.CoreFoundation      	0x00007fff841b7486 CFRunLoopRunSpecific + 230
10  com.apple.Foundation          	0x00007fff846c5f7b -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 267
11  DumpRenderTree                	0x000000010f719709 _ZL7runTestRKNSt3__112basic_stringIcNS_11char_traitsIcEENS_9allocatorIcEEEE + 5017 (DumpRenderTree.mm:1384)
12  DumpRenderTree                	0x000000010f7182fa _ZL20runTestingServerLoopv + 282 (DumpRenderTree.mm:844)
13  DumpRenderTree                	0x000000010f717cf5 dumpRenderTree(int, char const**) + 405 (DumpRenderTree.mm:899)
14  DumpRenderTree                	0x000000010f719ef9 main + 105 (DumpRenderTree.mm:937)
15  DumpRenderTree                	0x000000010f702224 start + 52

Comment 42 Sam Weinig 2013-04-16 18:22:45 PDT

Fixed in http://trac.webkit.org/changeset/148584.

abecsi
aboxhall
allan.jensen
apinheiro
buildbot
cfleizach
cmarcelo
commit-queue
dmazzoni
d-r
eric.carlson
esprehn+autocc
fmalita
gtk-ews
japhet
jberlin
jdiggs
jer.noble
menard
mifenton
pdr
philn
rego+ews
rniwa
schenney
simon.fraser
tkent
WebkitBugTracker
webkit-ews
xan.lopez