Bug 114641 - ScriptWrappable subclasses shouldn't have to include WeakInlines.h
Summary: ScriptWrappable subclasses shouldn't have to include WeakInlines.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-15 14:47 PDT by Anders Carlsson
Modified: 2013-04-15 20:31 PDT (History)
8 users (show)

See Also:


Attachments
Patch (18.51 KB, patch)
2013-04-15 16:03 PDT, Anders Carlsson
no flags Details | Formatted Diff | Diff
Patch (20.38 KB, patch)
2013-04-15 16:09 PDT, Anders Carlsson
ap: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-04-15 14:47:40 PDT
ScriptWrappable subclasses shouldn't have to include WeakInlines.h
Comment 1 Anders Carlsson 2013-04-15 16:03:02 PDT
Created attachment 198197 [details]
Patch
Comment 2 Anders Carlsson 2013-04-15 16:09:51 PDT
Created attachment 198198 [details]
Patch
Comment 3 Build Bot 2013-04-15 16:54:35 PDT
Comment on attachment 198198 [details]
Patch

Attachment 198198 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/94094
Comment 4 Anders Carlsson 2013-04-15 17:20:37 PDT
Committed r148479: <http://trac.webkit.org/changeset/148479>
Comment 5 Ryosuke Niwa 2013-04-15 20:31:44 PDT
It seems like this patch caused Windows clean builds to fail?

e.g. http://webkit-queues.appspot.com/results/146209