Bug 114635 - Remove files related to quota and proximity events from the Xcode project
Summary: Remove files related to quota and proximity events from the Xcode project
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-15 13:45 PDT by Anders Carlsson
Modified: 2013-04-15 14:18 PDT (History)
0 users

See Also:

Attachments
Patch (30.19 KB, patch)
2013-04-15 13:48 PDT, Anders Carlsson 		benjamin: review+
benjamin: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-04-15 13:45:52 PDT 
Remove files related to quota and proximity events from the Xcode project
Comment 1 Anders Carlsson 2013-04-15 13:48:10 PDT 
Created attachment 198182 [details]
Patch
Comment 2 Benjamin Poulain 2013-04-15 13:53:23 PDT 
Comment on attachment 198182 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198182&action=review

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:6839
> +		1ACF735D171C9A5B00C9BB1E /* DOMWindowQuota.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = DOMWindowQuota.h; sourceTree = "<group>"; };
> +		1ACF7372171C9AD400C9BB1E /* NavigatorStorageQuota.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = NavigatorStorageQuota.h; sourceTree = "<group>"; };
> +		1ACF7374171C9B7F00C9BB1E /* WorkerNavigatorStorageQuota.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WorkerNavigatorStorageQuota.h; sourceTree = "<group>"; };

I think reinserting DOMWindowQuota.h and WorkerNavigatorStorageQuota.h could cause issues on the iOS project file.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:20884
>  				49E912AB0EFAC906009D0CAF /* Animation.h in Headers */,
>  				316FE1120E6E1DA700BF6088 /* AnimationBase.h in Headers */,
> +				1ACF7375171C9B7F00C9BB1E /* WorkerNavigatorStorageQuota.h in Headers */,
>  				316FE1140E6E1DA700BF6088 /* AnimationController.h in Headers */,

The file section should be sorted alphabetically.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:23713
>  				B2C3DA420D006C1D00EF6F26 /* TextCodecUTF16.h in Headers */,
> +				1ACF7373171C9AD400C9BB1E /* NavigatorStorageQuota.h in Headers */,
>  				9343CB8212F25E510033C5EE /* TextCodecUTF8.h in Headers */,

The file section should be sorted alphabetically.
Comment 3 Anders Carlsson 2013-04-15 14:18:24 PDT 
Committed r148467: <http://trac.webkit.org/changeset/148467>