Bug 114633 - [BlackBerry] Crash from null m_webSettings in WebPagePrivate
Summary: [BlackBerry] Crash from null m_webSettings in WebPagePrivate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Liam Quinn
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-15 13:24 PDT by Liam Quinn
Modified: 2013-04-15 14:05 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.05 KB, patch)
2013-04-15 13:33 PDT, Liam Quinn 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Liam Quinn 2013-04-15 13:24:14 PDT 
We've had a few reports of crashes from a null m_webSettings in WebPagePrivate. As a speculative fix suggested by George Staikos, we should move the initialization of m_webSettings to the top of the init() method.
Comment 1 Liam Quinn 2013-04-15 13:33:04 PDT 
Created attachment 198177 [details]
Patch
Comment 2 Rob Buis 2013-04-15 13:36:48 PDT 
Comment on attachment 198177 [details]
Patch

Can't hurt.
Comment 3 WebKit Commit Bot 2013-04-15 14:05:43 PDT 
Comment on attachment 198177 [details]
Patch

Clearing flags on attachment: 198177

Committed r148466: <http://trac.webkit.org/changeset/148466>
Comment 4 WebKit Commit Bot 2013-04-15 14:05:45 PDT 
All reviewed patches have been landed.  Closing bug.