Remove unneeded headers from ScriptExecutionContext.h
Created attachment 198172 [details] Patch
Created attachment 198176 [details] Patch
Comment on attachment 198176 [details] Patch Attachment 198176 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/57461
Comment on attachment 198176 [details] Patch Attachment 198176 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-queues.appspot.com/results/114206
Comment on attachment 198176 [details] Patch Attachment 198176 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/119192
Comment on attachment 198176 [details] Patch Attachment 198176 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/57466
Comment on attachment 198176 [details] Patch Attachment 198176 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/8211
Comment on attachment 198176 [details] Patch Attachment 198176 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/57478
Comment on attachment 198176 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=198176&action=review r=me once everything is green. > Source/WebCore/dom/ScriptExecutionContext.h:54 > +typedef JSC::ExecState ScriptState; Can we move ScriptStateProtectedPtr into a separate header from ScriptState.h instead?
Comment on attachment 198176 [details] Patch Attachment 198176 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/110246
Created attachment 198206 [details] Patch
(In reply to comment #9) > (From update of attachment 198176 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=198176&action=review > > r=me once everything is green. > > > Source/WebCore/dom/ScriptExecutionContext.h:54 > > +typedef JSC::ExecState ScriptState; > > Can we move ScriptStateProtectedPtr into a separate header from ScriptState.h instead? I think we can just get rid of ScriptStateProtectedPtr - itβs one of the many V8 abstractions that are no longer needed.
Created attachment 198212 [details] Patch
Comment on attachment 198212 [details] Patch Attachment 198212 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/160029
Created attachment 198346 [details] Patch
Committed r148536: <http://trac.webkit.org/changeset/148536>
Comment on attachment 198346 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=198346&action=review > Source/WebCore/dom/ScriptExecutionContext.h:-43 > -#include <wtf/PassOwnPtr.h> (OwnPtr and PassOwnPtr are used in this .h file, so they are somehow included anyways.)
This broke the build on the Qt Windows 32bit Debug bot.