Bug 114621 - Initialize logging channels for web processes
Summary: Initialize logging channels for web processes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Balazs Kelemen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-15 05:49 PDT by Balazs Kelemen
Modified: 2013-04-22 02:11 PDT (History)
8 users (show)

See Also:


Attachments
Patch (5.92 KB, patch)
2013-04-15 06:05 PDT, Balazs Kelemen
no flags Details | Formatted Diff | Diff
Patch (7.22 KB, patch)
2013-04-16 01:40 PDT, Balazs Kelemen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kelemen 2013-04-15 05:49:27 PDT
Yet another trick to make debugging WebKit2 even more fun.
Comment 1 Balazs Kelemen 2013-04-15 06:05:14 PDT
Created attachment 198119 [details]
Patch
Comment 2 Alexey Proskuryakov 2013-04-15 11:36:38 PDT
Comment on attachment 198119 [details]
Patch

Looks OK. Where do you initialize WebKit2 logging channels though, why are they not together? This is what we have on Mac:

#if !LOG_DISABLED
    WebCore::initializeLoggingChannelsIfNecessary();
    WebKit::initializeLogChannelsIfNecessary();
#endif // !LOG_DISABLED
Comment 3 Balazs Kelemen 2013-04-16 01:39:03 PDT
(In reply to comment #2)
> (From update of attachment 198119 [details])
> Looks OK. Where do you initialize WebKit2 logging channels though, why are they not together? This is what we have on Mac:
> 
> #if !LOG_DISABLED
>     WebCore::initializeLoggingChannelsIfNecessary();
>     WebKit::initializeLogChannelsIfNecessary();
> #endif // !LOG_DISABLED

I searched for but did not find this code. It seems to be a better solution to use this shared code for every initialization.
Comment 4 Balazs Kelemen 2013-04-16 01:40:02 PDT
Created attachment 198276 [details]
Patch
Comment 5 Balazs Kelemen 2013-04-22 02:11:42 PDT
Comment on attachment 198276 [details]
Patch

Landed in 148519