Bug 114598 - Remove unused AlternativeTextClient::dismissDictationAlternativeUI
Summary: Remove unused AlternativeTextClient::dismissDictationAlternativeUI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-14 17:38 PDT by Alexey Proskuryakov
Modified: 2013-04-16 11:54 PDT (History)
5 users (show)

See Also:

Attachments
proposed patch (13.02 KB, patch)
2013-04-14 17:40 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-04-14 17:38:03 PDT 
AlternativeTextClient::dismissDictationAlternativeUI is never called. It hasn't been touched in a long time, so it looks more like dead code than part of a plan in progress.
Comment 1 Alexey Proskuryakov 2013-04-14 17:40:50 PDT 
Created attachment 198017 [details]
proposed patch

I do not know much about this code, so if you are aware of a reason to keep this function, please tell.
Comment 2 Jia Pu 2013-04-15 17:57:46 PDT 
This function can be removed, since dismissal of both correction and dictionary alternative is done by WebAlterantiveTextClient::dismissAlternative() in both WK and WK2.
Comment 3 WebKit Commit Bot 2013-04-16 11:54:56 PDT 
Comment on attachment 198017 [details]
proposed patch

Clearing flags on attachment: 198017

Committed r148531: <http://trac.webkit.org/changeset/148531>
Comment 4 WebKit Commit Bot 2013-04-16 11:54:58 PDT 
All reviewed patches have been landed.  Closing bug.