Bug 114593 - [EFL][WK2] Regression(r148274): Broke rendering in the browser
Summary: [EFL][WK2] Regression(r148274): Broke rendering in the browser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Blocker
Assignee: Chris Dumez
URL:
Keywords: Regression
Depends on:
Blocks: 110463
  Show dependency tree / graph
 
Reported: 2013-04-14 11:40 PDT by Chris Dumez
Modified: 2013-04-15 01:04 PDT (History)
10 users (show)

See Also:

Attachments
Patch (1.44 KB, patch)
2013-04-14 11:42 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-04-14 11:40:17 PDT 
<http://trac.webkit.org/changeset/148274> completely broke rendering in the browser. The view stays grey and the browser is unusable.

That patch defined a new "didChangeViewportAttributes" callback but forgot to hook it up in the view client.

Patch is on the way.
Comment 1 Chris Dumez 2013-04-14 11:42:40 PDT 
Created attachment 198006 [details]
Patch
Comment 2 WebKit Commit Bot 2013-04-14 12:16:06 PDT 
Comment on attachment 198006 [details]
Patch

Clearing flags on attachment: 198006

Committed r148407: <http://trac.webkit.org/changeset/148407>
Comment 3 WebKit Commit Bot 2013-04-14 12:16:10 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Mikhail Pozdnyakov 2013-04-15 01:04:16 PDT 
(In reply to comment #0)
> <http://trac.webkit.org/changeset/148274> completely broke rendering in the browser. The view stays grey and the browser is unusable.
> 
> That patch defined a new "didChangeViewportAttributes" callback but forgot to hook it up in the view client.
> 

Ahh, I lost it while rebasing :( Thanks Chris for fixing.